Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043364Retail ModulesWeb POSpublic2020-02-28 10:402020-03-23 09:01
ReporterAugustoMauch 
Assigned Torqueralta 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q2 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043364: The layout is wrong when there are more than 6 payment methods in the Count Cash window
DescriptionIf there are more than 6 payment methods shown in the Count Cash step of the cashup, the numeric pad layout is wrong and the enter key is not shown.

See attached image.
Steps To ReproduceI reproduced it https://livebuilds.openbravo.com/retail_modules_pgsql_pi [^]

In the backend:
- Open the touchpoint type YS POS Terminal Type
- In the Payment method subtab, mark all payment methods as:Count Payment in Cashup = true, Count Cash = false

In the webpos
- Login in terminal YS-11
- Do a cashup (you might need to first finish the current one to reload the payment method info).
- In the count cash step the layout will be wrong (see attached image)
Proposed Solution
Additional Information
TagsNOR
Relationships
related to defect 0043537 new Retail "More" payment methods buttons in CashUp are wrong 
Attached Filespng WrongLayoutInCashup.png (186,964) 2020-02-28 10:41
https://issues.openbravo.com/file_download.php?file_id=14110&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2020-02-28 10:40AugustoMauchNew Issue
2020-02-28 10:40AugustoMauchAssigned To => Retail
2020-02-28 10:40AugustoMauchTriggers an Emergency Pack => No
2020-02-28 10:41AugustoMauchFile Added: WrongLayoutInCashup.png
2020-02-28 10:45AugustoMauchResolution time => 1584054000
2020-02-28 12:40rafarodaTag Attached: NOR
2020-03-02 19:52rqueraltaAssigned ToRetail => rqueralta
2020-03-02 19:52rqueraltaStatusnew => scheduled
2020-03-05 13:46hgbotCheckin
2020-03-05 13:46hgbotNote Added: 0118342
2020-03-05 13:46hgbotStatusscheduled => resolved
2020-03-05 13:46hgbotResolutionopen => fixed
2020-03-05 13:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1193489d41a0e200aa0a1db5f96e1e21f23a1e9f [^]
2020-03-12 17:43jorge-garciaReview Assigned To => jorge-garcia
2020-03-12 18:03jorge-garciaNote Added: 0118561
2020-03-12 18:03jorge-garciaStatusresolved => new
2020-03-12 18:03jorge-garciaResolutionfixed => open
2020-03-16 20:14hgbotCheckin
2020-03-16 20:14hgbotNote Added: 0118632
2020-03-16 20:14hgbotStatusnew => resolved
2020-03-16 20:14hgbotResolutionopen => fixed
2020-03-16 20:14hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1193489d41a0e200aa0a1db5f96e1e21f23a1e9f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0bb70167adb0f0eb6a9fc598c6428e727072d3ff [^]
2020-03-16 20:14hgbotCheckin
2020-03-16 20:14hgbotNote Added: 0118633
2020-03-16 20:14hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0bb70167adb0f0eb6a9fc598c6428e727072d3ff [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4ce5aa1b2b73f76d2e491866c58934de22a3065b [^]
2020-03-23 09:00jorge-garciaRelationship addedrelated to 0043537
2020-03-23 09:01jorge-garciaNote Added: 0118744
2020-03-23 09:01jorge-garciaStatusresolved => closed
2020-03-23 09:01jorge-garciaFixed in Version => RR20Q2

Notes
(0118342)
hgbot   
2020-03-05 13:46   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1193489d41a0e200aa0a1db5f96e1e21f23a1e9f
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Mar 04 18:48:31 2020 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1193489d41a0e200aa0a1db5f96e1e21f23a1e9f [^]

Fixed BUG-43364: The layout is wrong when there are more than 6 payment methods
in the Count Cash window

- Added min-height to this class and change the height to 100%

---
M web/org.openbravo.retail.posterminal/css/obpos-main.css
---
(0118561)
jorge-garcia   
2020-03-12 18:03   
The solution works and the buttons from keypad are shown, but the layout is still broken.

The "clock" component and the keyboard in Cashup should be always in the same relative position in all steps.

The propose solution is to check step 1 (in which the cashier declares how many coins and bills are of each type for the payment method) and replicate the behavior in the next step
(0118632)
hgbot   
2020-03-16 20:14   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0bb70167adb0f0eb6a9fc598c6428e727072d3ff
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Sun Mar 15 10:26:33 2020 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0bb70167adb0f0eb6a9fc598c6428e727072d3ff [^]

Fixed BUG-43364: The layout is wrong when there are more than 6 payment methods
in the Count Cash window

- Reverted this changes because was fixed in mobile core module css class

---
M web/org.openbravo.retail.posterminal/css/obpos-main.css
---
(0118633)
hgbot   
2020-03-16 20:14   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 4ce5aa1b2b73f76d2e491866c58934de22a3065b
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Sun Mar 15 10:28:06 2020 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4ce5aa1b2b73f76d2e491866c58934de22a3065b [^]

Fixed BUG-43364: The layout is wrong when there are more than 6 payment methods
in the Count Cash window

- Remove css class that broke the layout and change the button heigth

---
M web/org.openbravo.mobile.core/assets/css/obmobc-main.css
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0118744)
jorge-garcia   
2020-03-23 09:01   
Code reviewed and tested