Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043363Openbravo ERPA. Platformpublic2020-02-28 10:222020-03-12 17:25
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043363: unneded requests to StaticResources when working in cluster
DescriptionWorking in a Tomcat cluster, the StaticResources generated JavaScript file is different among different nodes.

At least OB.Application.communityBrandingStaticUrl contains macIdentfier which makes the whole file to be different.

This causes unneeded requests to resources that should have been cached when switching between nodes.
Steps To ReproduceIn a cluster with 2 nodes in different physical machines:

1. log in to node A
  -> OK: StaticResources request is done
2. in same browser, log in to node B
  -> ERROR: a new request to StaticResources request is done, this shouldn't happen as it is already cached in the browser.
Proposed SolutionMove OB.Application.communityBrandingStaticUrl to SessionDynamic request
Additional Information
TagsPerformance
Relationships
related to design defect 0034490 acknowledged Triage Platform Base Openbravo ERP [clustering] Support clustering 
depends on defect 0043472 closed alostale Openbravo ERP API change: removed ApplicationComponent.getCommunityBrandingUrl method 
related to feature request 0035553 closed caristu Openbravo ERP Improve scalability of the login process 
related to defect 0043366 closed ranjith_qualiantech_com Retail Modules Cache manifest doesn't guarantee file order consistency, which can lead to unnecessary sources reloading 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-02-28 10:22alostaleNew Issue
2020-02-28 10:22alostaleAssigned To => platform
2020-02-28 10:22alostaleModules => Core
2020-02-28 10:22alostaleTriggers an Emergency Pack => No
2020-02-28 10:22alostaleTag Attached: Performance
2020-02-28 10:31alostaleRelationship addedrelated to 0035553
2020-02-28 10:33alostaleRelationship addedrelated to 0034490
2020-02-28 10:53marvintmRelationship addedrelated to 0043366
2020-03-06 14:12ioritzCiaResolution time => 1584658800
2020-03-06 14:12ioritzCiaNote Added: 0118385
2020-03-10 16:26alostaleAssigned Toplatform => alostale
2020-03-10 16:28alostaleRelationship addeddepends on 0043472
2020-03-10 16:39hgbotCheckin
2020-03-10 16:39hgbotNote Added: 0118473
2020-03-10 16:39hgbotStatusnew => resolved
2020-03-10 16:39hgbotResolutionopen => fixed
2020-03-10 16:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f4ae851af9065e44ae325b544602b9b9f4d5fa26 [^]
2020-03-10 16:42alostaleReview Assigned To => caristu
2020-03-12 17:25caristuNote Added: 0118557
2020-03-12 17:25caristuStatusresolved => closed

Notes
(0118385)
ioritzCia   
2020-03-06 14:12   
Putting a resolution time as it is related with bandwidth increase in a Gold customer
(0118473)
hgbot   
2020-03-10 16:39   
Repository: erp/devel/pi
Changeset: f4ae851af9065e44ae325b544602b9b9f4d5fa26
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Mar 02 11:28:09 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f4ae851af9065e44ae325b544602b9b9f4d5fa26 [^]

fixed BUG-43363: unneded requests to StaticResources when working in cluster

  Community branding URL was included as static resource. As it contains
  mac identifier information that varies among nodes in the same
  cluster, generated js file was different and requested whenver a
  browser switched from a node to another.

  Now this part has been moved to SessionDynamic request.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/ApplicationComponent.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/ApplicationDynamicComponent.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-dynamic-js.ftl
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-js.ftl
---
(0118557)
caristu   
2020-03-12 17:25   
Reviewed + tested OK.

MR: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/49 [^]