Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043336Openbravo ERPA. Platformpublic2020-02-26 11:452020-03-06 12:29
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043336: Apply new HQL Style in CancelAndReplaceUtils.java
DescriptionCancelAndReplaceUtils.java has two HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-02-26 11:45inigo_lergaNew Issue
2020-02-26 11:45inigo_lergaAssigned To => inigo_lerga
2020-02-26 11:45inigo_lergaModules => Core
2020-02-26 11:45inigo_lergaTriggers an Emergency Pack => No
2020-02-26 11:45inigo_lergaRelationship addedrelated to 0041287
2020-02-26 11:45inigo_lergaStatusnew => scheduled
2020-02-26 12:43inigo_lergaNote Added: 0118118
2020-02-26 13:51inigo_lergaDescription Updatedbug_revision_view_page.php?rev_id=20455#r20455
2020-03-06 12:28hgbotCheckin
2020-03-06 12:28hgbotNote Added: 0118367
2020-03-06 12:28hgbotStatusscheduled => resolved
2020-03-06 12:28hgbotResolutionopen => fixed
2020-03-06 12:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6dd3ae016011882cf62c99d7bb5dee8386afa6e1 [^]
2020-03-06 12:28hgbotCheckin
2020-03-06 12:28hgbotNote Added: 0118368
2020-03-06 12:29dmiguelezReview Assigned To => dmiguelez
2020-03-06 12:29dmiguelezNote Added: 0118369
2020-03-06 12:29dmiguelezStatusresolved => closed
2020-03-06 12:29dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0118118)
inigo_lerga   
2020-02-26 12:43   
--Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
  - Go to the Preference window and create a new record with
    "Enable Cancel and Replace" as Property and Value "Y".
    Save, Log out and Log in again.
  - Go to the Sales Order window and create a new record with
    any Business Partner desired.
  - Go to the Lines Tab and create a new Line with any desired
    product and quantity.
  - Save the Sales Order record and Book it.
    Press now the Cancel and Replace Button and Done button in
    the popup window.
    Now Press the Confirm Cancel and Replace Button and Done
    button in the popup window.
    
    #In this moment the modified HQLs are executed#
(0118367)
hgbot   
2020-03-06 12:28   
Repository: erp/devel/pi
Changeset: 6dd3ae016011882cf62c99d7bb5dee8386afa6e1
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Feb 26 12:56:37 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6dd3ae016011882cf62c99d7bb5dee8386afa6e1 [^]

fixes BUG-43336:Applied new HQL Style

---
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
---
(0118368)
hgbot   
2020-03-06 12:28   
Repository: erp/devel/pi
Changeset: 09285ef380dfdf2743c74f81fbe2ec0a6768baa5
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Feb 26 13:46:14 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/09285ef380dfdf2743c74f81fbe2ec0a6768baa5 [^]

related to ISSUE-43336: Applied Sonarlint suggestions and more

-Finals added
-Sonarlint suggestions applied

---
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
---
(0118369)
dmiguelez   
2020-03-06 12:29   
Code Review + Testing Ok