Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0043324Openbravo ERPA. Platformpublic2020-02-25 12:522020-03-06 12:14
inigo_lerga 
inigo_lerga 
normalminorhave not tried
closedfixed 
5
 
3.0PR20Q2 
dmiguelez
Core
No
0043324: Apply new HQL Style in ReportValuationStock.java
ReportValuationStock.java has three HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
-
Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
No tags attached.
related to design defect 0041287 acknowledged platform Tracking issue: Convert HQL to apply new style 
Issue History
2020-02-25 12:52inigo_lergaNew Issue
2020-02-25 12:52inigo_lergaAssigned To => inigo_lerga
2020-02-25 12:52inigo_lergaModules => Core
2020-02-25 12:52inigo_lergaTriggers an Emergency Pack => No
2020-02-25 12:52inigo_lergaRelationship addedrelated to 0041287
2020-02-25 12:53inigo_lergaStatusnew => scheduled
2020-02-26 09:39inigo_lergaNote Added: 0118107
2020-03-06 12:13hgbotCheckin
2020-03-06 12:13hgbotNote Added: 0118364
2020-03-06 12:13hgbotStatusscheduled => resolved
2020-03-06 12:13hgbotResolutionopen => fixed
2020-03-06 12:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1cde459b3d26eff7b73c7404261ea8719f8a8e80 [^]
2020-03-06 12:13hgbotCheckin
2020-03-06 12:13hgbotNote Added: 0118365
2020-03-06 12:14dmiguelezReview Assigned To => dmiguelez
2020-03-06 12:14dmiguelezNote Added: 0118366
2020-03-06 12:14dmiguelezStatusresolved => closed
2020-03-06 12:14dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0118107)
inigo_lerga   
2020-02-26 09:39   
--Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
  - Go to the Valued Stock Report window. Select the
    Organization "F&B España - Región Norte" and
    press the HTML Format button.
    
    #In this moment the modified HQLs are executed#
(0118364)
hgbot   
2020-03-06 12:13   
Repository: erp/devel/pi
Changeset: 1cde459b3d26eff7b73c7404261ea8719f8a8e80
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Feb 26 09:40:47 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1cde459b3d26eff7b73c7404261ea8719f8a8e80 [^]

fixes BUG-43324:Applied new HQL Style

---
M src/org/openbravo/erpCommon/ad_reports/ReportValuationStock.java
---
(0118365)
hgbot   
2020-03-06 12:13   
Repository: erp/devel/pi
Changeset: 039388524b254c8f52b34d2f8e8e16871ef4bd40
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Mar 06 12:06:01 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/039388524b254c8f52b34d2f8e8e16871ef4bd40 [^]

Related to ISSUE-43324. Renamed variables

---
M src/org/openbravo/erpCommon/ad_reports/ReportValuationStock.java
---
(0118366)
dmiguelez   
2020-03-06 12:14   
Code Review + Testing Ok