Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043322Retail ModulesDiscounts by Totalpublic2020-02-25 11:512020-03-05 19:23
ReporterLeyre 
Assigned Torqueralta 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerGold
Support ticket14891
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043322: The "By Total" discount does not apply correctly the discounted qty. on the receipt lines
DescriptionThe "By Total" discount does not apply correctly the discounted qty. on the receipt lines
Steps To ReproduceBackend:
Set the "Web POS Use advanced discounts engine" preference = N

Web POS:
1. Add two lines with prices:
   Line 1 - P1 100
   Line 2 - P2 200

2. Add a discount type = User Defined Amount of 50 to the second line
   Line 1 - P1 100
   Line 2 - P2 200-50=100

3. Add a discount type = Variable Discount per Total Amount of 180 to the receipt.

Verify that the second discount should be applied proportionally on the lines of quantity, but it applies incorrectly:
   P1 = -60
   P2 = -100
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041887 closed rqueralta The "By Total" discount does not apply correctly the discounted qty. on the receipt lines, since it does review other discounts 
related to defect 0043880 closed ranjith_qualiantech_com Using the old discount engine, the "by total" discount is not calculated correctly on the receipt lines 
causes defect 0043521 closed rqueralta The by total discount is not applied correctly to the receipt lines 
Attached Filespng image.png (112,911) 2020-02-25 11:51
https://issues.openbravo.com/file_download.php?file_id=14087&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2020-02-25 11:51LeyreNew Issue
2020-02-25 11:51LeyreAssigned To => Retail
2020-02-25 11:51LeyreFile Added: image.png
2020-02-25 11:51LeyreOBNetwork customer => Gold
2020-02-25 11:51LeyreSupport ticket => 14891
2020-02-25 11:51LeyreResolution time => 1584399600
2020-02-25 11:51LeyreTriggers an Emergency Pack => No
2020-02-25 11:52LeyreRelationship addedrelated to 0041887
2020-02-25 13:26rqueraltaAssigned ToRetail => rqueralta
2020-02-25 13:26rqueraltaStatusnew => scheduled
2020-02-26 17:22hgbotCheckin
2020-02-26 17:22hgbotNote Added: 0118126
2020-02-26 17:22hgbotStatusscheduled => resolved
2020-02-26 17:22hgbotResolutionopen => fixed
2020-02-26 17:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/5ab58c676f941bee01ad2158bdc234aa8248f70e [^]
2020-02-27 00:04hgbotCheckin
2020-02-27 00:04hgbotNote Added: 0118138
2020-03-05 19:23guilleaerReview Assigned To => guilleaer
2020-03-05 19:23guilleaerStatusresolved => closed
2020-03-05 19:23guilleaerFixed in Version => RR20Q2
2020-04-06 18:49ngarciaRelationship addedcauses 0043521
2020-04-27 13:43LeyreRelationship addedrelated to 0043880

Notes
(0118126)
hgbot   
2020-02-26 17:22   
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: 5ab58c676f941bee01ad2158bdc234aa8248f70e
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Feb 26 11:19:21 2020 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/5ab58c676f941bee01ad2158bdc234aa8248f70e [^]

Fixed BUG-43322: The "By Total" discount does not apply correctly the discounted
qty. on the receipt lines

- Total receipt discount was calculated separated of lines discount to update the
total receipt taking into the account the discounts previously applied

---
M web/org.openbravo.retail.discounts.bytotal/js/promotion-by-total-utils.js
---
(0118138)
hgbot   
2020-02-27 00:04   
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: 46fb87e0838ccf54e0d2f8e244179b2bb0662e5a
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Feb 26 18:03:45 2020 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/46fb87e0838ccf54e0d2f8e244179b2bb0662e5a [^]

Related to ISSUE-43322: The "By Total" discount does not apply correctly the
discounted qty. on the receipt lines

- Fixed problem with splitline product

---
M web/org.openbravo.retail.discounts.bytotal/js/promotion-by-total-utils.js
---