Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043305Openbravo ERPA. Platformpublic2020-02-24 14:252020-03-02 17:30
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043305: Apply new HQL Style in MRPPurchaseCreateReservations.java
DescriptionMRPPurchaseCreateReservations.java has two HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-02-24 14:25inigo_lergaNew Issue
2020-02-24 14:25inigo_lergaAssigned To => inigo_lerga
2020-02-24 14:25inigo_lergaOBNetwork customer => No
2020-02-24 14:25inigo_lergaModules => Core
2020-02-24 14:25inigo_lergaTriggers an Emergency Pack => No
2020-02-24 14:25inigo_lergaStatusnew => scheduled
2020-02-24 14:25inigo_lergaRelationship addedrelated to 0041287
2020-02-25 10:32inigo_lergaNote Added: 0118088
2020-03-02 17:29hgbotCheckin
2020-03-02 17:29hgbotNote Added: 0118268
2020-03-02 17:29hgbotStatusscheduled => resolved
2020-03-02 17:29hgbotResolutionopen => fixed
2020-03-02 17:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ffc9fd932dab6cf674cbca2b375e4076aea13a28 [^]
2020-03-02 17:29hgbotCheckin
2020-03-02 17:29hgbotNote Added: 0118269
2020-03-02 17:29hgbotCheckin
2020-03-02 17:29hgbotNote Added: 0118270
2020-03-02 17:30dmiguelezReview Assigned To => dmiguelez
2020-03-02 17:30dmiguelezNote Added: 0118271
2020-03-02 17:30dmiguelezStatusresolved => closed
2020-03-02 17:30dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0118088)
inigo_lerga   
2020-02-25 10:32   
--Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
  - Go to the Preference window and create a new record with
    "Enable Stock Reservations" as Property and "Y" as
    Value.
  - Go to the Purchasing Plan window (with an activated
    environment) and create a new record with any Name
    desired.
    Press the Create Reservations button and OK button
    in the popup window.

    #In this moment the modified HQLs are executed#
(0118268)
hgbot   
2020-03-02 17:29   
Repository: erp/devel/pi
Changeset: ffc9fd932dab6cf674cbca2b375e4076aea13a28
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Feb 25 09:54:05 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ffc9fd932dab6cf674cbca2b375e4076aea13a28 [^]

fixes BUG-43305:Applied new HQL Style

---
M src/org/openbravo/erpCommon/ad_process/MRPPurchaseCreateReservations.java
---
(0118269)
hgbot   
2020-03-02 17:29   
Repository: erp/devel/pi
Changeset: bc583dbe363ddf1c22030afedde917c5460f1f8c
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Feb 25 10:05:53 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/bc583dbe363ddf1c22030afedde917c5460f1f8c [^]

related to ISSUE-43305: Applied Sonarlint suggestions

---
M src/org/openbravo/erpCommon/ad_process/MRPPurchaseCreateReservations.java
---
(0118270)
hgbot   
2020-03-02 17:29   
Repository: erp/devel/pi
Changeset: a01177def4a29a0ddd62970b1144c6d6595c2a36
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Mar 02 17:29:15 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a01177def4a29a0ddd62970b1144c6d6595c2a36 [^]

Related to ISSUE-43305. Code Review changes:
* Changed variable name to reflect that it is an id
* Split case when clauses in different lines to improve
  redability

---
M src/org/openbravo/erpCommon/ad_process/MRPPurchaseCreateReservations.java
---
(0118271)
dmiguelez   
2020-03-02 17:30   
Code Review + Testing Ok