Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043298Openbravo ERPA. Platformpublic2020-02-24 10:592020-03-02 18:33
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043298: Apply new HQL Style in AssetLinearDepreciationMethodProcess.java
DescriptionAssetLinearDepreciationMethodProcess.java has three HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-02-24 10:59inigo_lergaNew Issue
2020-02-24 10:59inigo_lergaAssigned To => inigo_lerga
2020-02-24 10:59inigo_lergaOBNetwork customer => No
2020-02-24 10:59inigo_lergaModules => Core
2020-02-24 10:59inigo_lergaTriggers an Emergency Pack => No
2020-02-24 10:59inigo_lergaRelationship addedrelated to 0041287
2020-02-24 11:00inigo_lergaStatusnew => scheduled
2020-02-24 12:46inigo_lergaNote Added: 0118054
2020-03-02 16:48hgbotCheckin
2020-03-02 16:48hgbotNote Added: 0118261
2020-03-02 16:48hgbotStatusscheduled => resolved
2020-03-02 16:48hgbotResolutionopen => fixed
2020-03-02 16:48hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0102ce9fec17a85247b8cb067c6de5a0ae36e11b [^]
2020-03-02 16:48hgbotCheckin
2020-03-02 16:48hgbotNote Added: 0118262
2020-03-02 16:48hgbotCheckin
2020-03-02 16:48hgbotNote Added: 0118263
2020-03-02 16:49dmiguelezReview Assigned To => dmiguelez
2020-03-02 16:49dmiguelezNote Added: 0118264
2020-03-02 16:49dmiguelezStatusresolved => closed
2020-03-02 16:49dmiguelezFixed in Version => 3.0PR20Q2
2020-03-02 18:33hgbotCheckin
2020-03-02 18:33hgbotNote Added: 0118272

Notes
(0118054)
inigo_lerga   
2020-02-24 12:46   
--Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
  - Go to the Assets window and select the "Storage"
    record. Press the Create Amortization button
    and OK button in the popup window.
  
  #In this moment the modified HQLs are executed#
(0118261)
hgbot   
2020-03-02 16:48   
Repository: erp/devel/pi
Changeset: 0102ce9fec17a85247b8cb067c6de5a0ae36e11b
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Feb 24 12:47:22 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0102ce9fec17a85247b8cb067c6de5a0ae36e11b [^]

fixes BUG-43298:Applied new HQL Style

---
M src/org/openbravo/erpCommon/ad_process/assets/AssetLinearDepreciationMethodProcess.java
---
(0118262)
hgbot   
2020-03-02 16:48   
Repository: erp/devel/pi
Changeset: f66975bddbda4123103c7fb4c2553b7744329d7f
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Feb 24 14:02:46 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f66975bddbda4123103c7fb4c2553b7744329d7f [^]

related to ISSUE-43298: Applied Sonarlint suggestions + finals added

---
M src/org/openbravo/erpCommon/ad_process/assets/AssetLinearDepreciationMethodProcess.java
---
(0118263)
hgbot   
2020-03-02 16:48   
Repository: erp/devel/pi
Changeset: 0081cfb108afda2e064360af2a396030fcc3f373
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Mar 02 16:47:52 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0081cfb108afda2e064360af2a396030fcc3f373 [^]

Related to ISSUE-43298. Moved parameter in query to avoid unnecessary
format enablers/disablers

---
M src/org/openbravo/erpCommon/ad_process/assets/AssetLinearDepreciationMethodProcess.java
---
(0118264)
dmiguelez   
2020-03-02 16:49   
Code Review + Testing Ok
(0118272)
hgbot   
2020-03-02 18:33   
Repository: erp/devel/pi
Changeset: cb93d1d1453f03112ea0da6564474f71f5ecae50
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Mar 02 18:32:22 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cb93d1d1453f03112ea0da6564474f71f5ecae50 [^]

Related to ISSUE-43298. Adds accidentaly removed Exception thrown

---
M src/org/openbravo/erpCommon/ad_process/assets/AssetLinearDepreciationMethodProcess.java
---