Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043272Openbravo ERPA. Platformpublic2020-02-19 17:462020-02-28 07:49
Reportershuehner 
Assigned Tocberner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPackaging and release
Regression date2019-11-28
Regression introduced in releasemain
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/c47b63fff5775ab73ce8072af4fa6fd6c13d197e [^]
Triggers an Emergency PackNo
Summary0043272: When importing translation for no longer existing elements -> INFO message is missing all necessary details
DescriptionWhen importing translation values from a translation pack it can happen that the original row to be translated does no longer exist.

In that case a message is shown like the following:
     [java] 36825 [main] INFO org.openbravo.erpCommon.ad_forms.TranslationHandler - Not Found - UPDATE AD_TEXTINTERFACES_Trl SET Text='Sous-total de la Grille',Updated=now(),IsTranslated='Y' WHERE AD_TEXTINTERFACES_ID='508174CC5C8C4E4B90AF19C2FE2A5B40' AND AD_Language='fr_FR' AND AD_Client_ID='0'

showing which translation is not finding its row to update.
Note that message is INFO level only as that is info useful to maintainer of the translation but not a problem for the user of the translation pack.

That message is now broken in pi as it looks like:
     [java] 35685 [main] INFO org.openbravo.erpCommon.ad_forms.TranslationHandler - Not Found - update AD_TEXTINTERFACES_Trl set Text=?,Updated=now() ,IsTranslated=? where AD_TEXTINTERFACES_ID=? and AD_Language=? and AD_Client_ID=?

That is side-effect of improving the code to use SQL bind-parameters.
The values interesting to print are now parameter-values but the code is only printing the sql-string
Steps To ReproduceInstall a translation having at least 1 trl value for which the original row does no longer exist.
Review the 'Not Found' to notice all reference to the element are missing
Proposed Solution-
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00433173.0PR20Q1 closed cberner When importing translation for no longer existing elements -> INFO message is missing all necessary details 
caused by defect 0041942 closed cberner Apply new HQL Style to platform classes 
related to defect 0043686 closed cberner TranslationHandler shows INFO of not found after each ERROR 
related to defect 0043687 closed cberner TranslationHandler does not cancel on first exception and makes more transactions 
causes defect 0043685 closed cberner Re-add exception message when error importing translations 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-02-19 17:46shuehnerNew Issue
2020-02-19 17:46shuehnerAssigned To => platform
2020-02-19 17:46shuehnerModules => Core
2020-02-19 17:46shuehnerRegression level => Packaging and release
2020-02-19 17:46shuehnerRegression date => 2019-11-28
2020-02-19 17:46shuehnerRegression introduced in release => main
2020-02-19 17:46shuehnerRegression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/c47b63fff5775ab73ce8072af4fa6fd6c13d197e [^]
2020-02-19 17:46shuehnerTriggers an Emergency Pack => No
2020-02-19 17:47shuehnerRelationship addedcaused by 0041942
2020-02-19 19:00cbernerAssigned Toplatform => cberner
2020-02-21 08:09alostaleSeveritymajor => minor
2020-02-25 09:20hgbotCheckin
2020-02-25 09:20hgbotNote Added: 0118072
2020-02-25 09:20hgbotStatusnew => resolved
2020-02-25 09:20hgbotResolutionopen => fixed
2020-02-25 09:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/33db07200942157629e9ab28df79b49bfb675960 [^]
2020-02-25 09:52cbernerNote Added: 0118083
2020-02-25 09:52cbernerStatusresolved => new
2020-02-25 09:52cbernerResolutionfixed => open
2020-02-25 09:56cbernerStatusnew => scheduled
2020-02-25 09:58cbernerStatusscheduled => resolved
2020-02-25 09:58cbernerResolutionopen => fixed
2020-02-25 12:37cbernerNote Deleted: 0118083
2020-02-25 12:38cbernerNote Added: 0118093
2020-02-28 07:49alostaleReview Assigned To => alostale
2020-02-28 07:49alostaleNote Added: 0118193
2020-02-28 07:49alostaleStatusresolved => closed
2020-02-28 07:49alostaleFixed in Version => 3.0PR20Q2
2020-04-07 09:32cbernerRelationship addedcauses 0043685
2020-04-07 09:36cbernerRelationship addedrelated to 0043686
2020-04-07 09:42cbernerRelationship addedrelated to 0043687

Notes
(0118072)
hgbot   
2020-02-25 09:20   
Repository: erp/devel/pi
Changeset: 33db07200942157629e9ab28df79b49bfb675960
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Mon Feb 24 17:13:12 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/33db07200942157629e9ab28df79b49bfb675960 [^]

Fixes ISSUE-43272: Info message on importing missing translation shows params

---
M src/org/openbravo/erpCommon/ad_forms/TranslationHandler.java
---
(0118093)
cberner   
2020-02-25 12:38   
Reviewed in MR: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/46 [^]
(0118193)
alostale   
2020-02-28 07:49   
reviewed