Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0043267Openbravo ERPA. Platformpublic2020-02-19 14:472020-03-02 12:58
inigo_lerga 
inigo_lerga 
normalminorhave not tried
closedfixed 
5
 
3.0PR20Q2 
dmiguelez
Core
No
0043267: Apply new HQL Style in DocDoubtfulDebt.java
DocDoubtfulDebt.java has two HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
-
Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
No tags attached.
related to design defect 0041287 acknowledged platform Tracking issue: Convert HQL to apply new style 
Issue History
2020-02-19 14:47inigo_lergaNew Issue
2020-02-19 14:47inigo_lergaAssigned To => inigo_lerga
2020-02-19 14:47inigo_lergaModules => Core
2020-02-19 14:47inigo_lergaTriggers an Emergency Pack => No
2020-02-19 14:47inigo_lergaRelationship addedrelated to 0041287
2020-02-19 15:19inigo_lergaDescription Updatedbug_revision_view_page.php?rev_id=20411#r20411
2020-02-19 15:19inigo_lergaStatusnew => scheduled
2020-02-19 17:02inigo_lergaNote Added: 0117953
2020-03-02 12:56dmiguelezNote Edited: 0117953bug_revision_view_page.php?bugnote_id=0117953#r20488
2020-03-02 12:57hgbotCheckin
2020-03-02 12:57hgbotNote Added: 0118245
2020-03-02 12:57hgbotStatusscheduled => resolved
2020-03-02 12:57hgbotResolutionopen => fixed
2020-03-02 12:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c90d48fda937def6b279408dc81b3747dcff58bb [^]
2020-03-02 12:57hgbotCheckin
2020-03-02 12:57hgbotNote Added: 0118246
2020-03-02 12:58dmiguelezReview Assigned To => dmiguelez
2020-03-02 12:58dmiguelezNote Added: 0118247
2020-03-02 12:58dmiguelezStatusresolved => closed
2020-03-02 12:58dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0117953)
inigo_lerga   
2020-02-19 17:02   
(edited on: 2020-03-02 12:56)
--Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
    - Go to the Process Request window and select the
      "Acct Server Process" record and Unschedule it.
    - Create a new record in this same window with the Process
      "Acct Server Process" and "Run Inmediately" as Timing.
    - Go to Business Partner Category window and select: Customer - Tier 1
      - Go to Accouting Tab and fill the information for Doubtful Debt, Bad Debt Expense, Bad Debt Revenue and Allowance for Doubtful Debt Accounts for both General Ledgers.
    - Go to Sales Invoice window and create a new record
      with "Alimentos y Supermercados, S.A" as Business Partner.
      Make sure that the Invoice Date of the record is at least
      3 months before today.
      Go to the Lines Tab and create a new Line with "Agua sin Gas 1L"
      as Product and 70 as Invoice Quantity.
      Save the record and Complete it.
    - Go to the Doubtful Debt Run and create a new record. Select the
      Doubtful Debt that appears in the popup window after pressing
      the Select Doubtful Debt button. Press Done.
      Process the record.
    - Go back to the Process Request window and Schedule the previously
      created record.
      
    #In this moment the modified HQL is executed#

(0118245)
hgbot   
2020-03-02 12:57   
Repository: erp/devel/pi
Changeset: c90d48fda937def6b279408dc81b3747dcff58bb
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Feb 19 15:58:54 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c90d48fda937def6b279408dc81b3747dcff58bb [^]

fixes BUG-43267:Applied new HQL Style

---
M src/org/openbravo/erpCommon/ad_forms/DocDoubtfulDebt.java
---
(0118246)
hgbot   
2020-03-02 12:57   
Repository: erp/devel/pi
Changeset: 5a674509b3ac5ca03ae2d86f5e434599366be70b
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Feb 19 16:48:03 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5a674509b3ac5ca03ae2d86f5e434599366be70b [^]

related to ISSUE-43267: Applied Sonarlint suggestions and more

Sonarlint suggestions applied.
Finals added.

---
M src/org/openbravo/erpCommon/ad_forms/DocDoubtfulDebt.java
---
(0118247)
dmiguelez   
2020-03-02 12:58   
Code Review + Testing Ok