Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0043265Openbravo ERPA. Platformpublic2020-02-19 13:562020-03-02 12:40
inigo_lerga 
inigo_lerga 
normalminorhave not tried
closedfixed 
5
 
3.0PR20Q2 
dmiguelez
Core
No
0043265: Apply new HQL Style in SL_ProductPrice_PriceListVersion.java
SL_ProductPrice_PriceListVersion.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
-
Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
No tags attached.
related to design defect 0041287 acknowledged platform Tracking issue: Convert HQL to apply new style 
Issue History
2020-02-19 13:56inigo_lergaNew Issue
2020-02-19 13:56inigo_lergaAssigned To => inigo_lerga
2020-02-19 13:56inigo_lergaModules => Core
2020-02-19 13:56inigo_lergaTriggers an Emergency Pack => No
2020-02-19 13:57inigo_lergaRelationship addedrelated to 0041287
2020-02-19 14:15inigo_lergaStatusnew => scheduled
2020-03-02 12:40hgbotCheckin
2020-03-02 12:40hgbotNote Added: 0118243
2020-03-02 12:40hgbotStatusscheduled => resolved
2020-03-02 12:40hgbotResolutionopen => fixed
2020-03-02 12:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/845e19484c1bdbd0c84192baf10e622c02fa8a43 [^]
2020-03-02 12:40dmiguelezReview Assigned To => dmiguelez
2020-03-02 12:40dmiguelezNote Added: 0118244
2020-03-02 12:40dmiguelezStatusresolved => closed
2020-03-02 12:40dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0118243)
hgbot   
2020-03-02 12:40   
Repository: erp/devel/pi
Changeset: 845e19484c1bdbd0c84192baf10e622c02fa8a43
Author: IƱigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Feb 20 11:44:47 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/845e19484c1bdbd0c84192baf10e622c02fa8a43 [^]

fixes BUG-43265:Applied new HQL Style + finals added

---
M src/org/openbravo/erpCommon/ad_callouts/SL_ProductPrice_PriceListVersion.java
---
(0118244)
dmiguelez   
2020-03-02 12:40   
Code Review + Testing ok