Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043255Openbravo ERPA. Platformpublic2020-02-18 16:102020-03-02 12:16
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043255: Apply new HQL Style in SE_Locator_Activate.java
DescriptionCostAdjustmentUtils.java has 2 HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-02-18 16:10inigo_lergaNew Issue
2020-02-18 16:10inigo_lergaAssigned To => inigo_lerga
2020-02-18 16:10inigo_lergaModules => Core
2020-02-18 16:10inigo_lergaTriggers an Emergency Pack => No
2020-02-18 16:11inigo_lergaDescription Updatedbug_revision_view_page.php?rev_id=20402#r20402
2020-02-18 16:11inigo_lergaRelationship addedrelated to 0041287
2020-02-19 10:13inigo_lergaStatusnew => scheduled
2020-02-19 10:13inigo_lergaNote Added: 0117940
2020-03-02 12:15hgbotCheckin
2020-03-02 12:15hgbotNote Added: 0118236
2020-03-02 12:15hgbotStatusscheduled => resolved
2020-03-02 12:15hgbotResolutionopen => fixed
2020-03-02 12:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0740967153b327cbf1607e31011a416c35f894d9 [^]
2020-03-02 12:15hgbotCheckin
2020-03-02 12:15hgbotNote Added: 0118237
2020-03-02 12:15hgbotCheckin
2020-03-02 12:15hgbotNote Added: 0118238
2020-03-02 12:16dmiguelezReview Assigned To => dmiguelez
2020-03-02 12:16dmiguelezNote Added: 0118239
2020-03-02 12:16dmiguelezStatusresolved => closed
2020-03-02 12:16dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0117940)
inigo_lerga   
2020-02-19 10:13   
--Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
    - Go to the Warehouse and Storage Bins window and
      create a new record with any Search Key, Name and
      Location desired.
      Save the record.
      Press the Active checkbox to deactivate the record.
      
    #In this moment the modified HQL is executed#

    - In the previously created record, go to the Storage
      Bins Tab and create a new record with any Search Key,
      Row, Stack and Levels (X,Y,Z) desired.
      Save the record.
      Press the Active checkbox to deactivate the record.
    
    #In this moment the modified HQL is executed#
(0118236)
hgbot   
2020-03-02 12:15   
Repository: erp/devel/pi
Changeset: 0740967153b327cbf1607e31011a416c35f894d9
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Feb 19 10:14:50 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0740967153b327cbf1607e31011a416c35f894d9 [^]

fixes BUG-43255:Applied new HQL Style

---
M src/org/openbravo/erpCommon/ad_callouts/SE_Locator_Activate.java
---
(0118237)
hgbot   
2020-03-02 12:15   
Repository: erp/devel/pi
Changeset: 713fce4e12ba6181467d2fcdf3e95cbc45f49c4d
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Feb 19 10:28:02 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/713fce4e12ba6181467d2fcdf3e95cbc45f49c4d [^]

related to ISSUE-43255: Applied Sonarlint suggestions

Sonarlint suggestions applied.
Finals added.
Code refactored to be more legible in different methods.

---
M src/org/openbravo/erpCommon/ad_callouts/SE_Locator_Activate.java
---
(0118238)
hgbot   
2020-03-02 12:15   
Repository: erp/devel/pi
Changeset: 724a769ba66130bb22466bc4d6e56b50da3f53ae
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Mar 02 12:15:19 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/724a769ba66130bb22466bc4d6e56b50da3f53ae [^]

Related to ISSUE-43255. Reordered methods

---
M src/org/openbravo/erpCommon/ad_callouts/SE_Locator_Activate.java
---
(0118239)
dmiguelez   
2020-03-02 12:16   
Code Review + Testing Ok