Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043231Openbravo ERPA. Platformpublic2020-02-17 10:582020-02-27 17:01
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043231: Apply new HQL Style in MRPManufacturingPlanProcess.java
DescriptionMRPManufacturingPlanProcess.java has two HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-02-17 10:58inigo_lergaNew Issue
2020-02-17 10:58inigo_lergaAssigned To => platform
2020-02-17 10:58inigo_lergaOBNetwork customer => No
2020-02-17 10:58inigo_lergaModules => Core
2020-02-17 10:58inigo_lergaTriggers an Emergency Pack => No
2020-02-17 10:58inigo_lergaRelationship addedrelated to 0041287
2020-02-17 11:14inigo_lergaStatusnew => scheduled
2020-02-17 11:14inigo_lergaAssigned Toplatform => inigo_lerga
2020-02-18 09:39inigo_lergaNote Added: 0117893
2020-02-27 17:00hgbotCheckin
2020-02-27 17:00hgbotNote Added: 0118177
2020-02-27 17:00hgbotStatusscheduled => resolved
2020-02-27 17:00hgbotResolutionopen => fixed
2020-02-27 17:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0eb0e681a931aa7d0dfed2171ad6afeab743ae93 [^]
2020-02-27 17:00hgbotCheckin
2020-02-27 17:00hgbotNote Added: 0118178
2020-02-27 17:01dmiguelezReview Assigned To => dmiguelez
2020-02-27 17:01dmiguelezNote Added: 0118179
2020-02-27 17:01dmiguelezStatusresolved => closed
2020-02-27 17:01dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0117893)
inigo_lerga   
2020-02-18 09:39   
--Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
    - Go to the Manufacturing Plan window (with an activated
      environment).
      Create a new record, write any Name desired for the Name
      field.
      Save the record and Press the Process Manufacturing Plan button.
      OK button in the popup window.

    #In this moment the modified HQLs are executed#
(0118177)
hgbot   
2020-02-27 17:00   
Repository: erp/devel/pi
Changeset: 0eb0e681a931aa7d0dfed2171ad6afeab743ae93
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Feb 18 09:11:05 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0eb0e681a931aa7d0dfed2171ad6afeab743ae93 [^]

fixes BUG-43231:Applied new HQL Style

---
M src/org/openbravo/erpCommon/ad_actionButton/MRPManufacturingPlanProcess.java
---
(0118178)
hgbot   
2020-02-27 17:00   
Repository: erp/devel/pi
Changeset: f2342ef327b98eb222686ef4fb7f5b0a67ac532f
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Feb 18 09:32:04 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f2342ef327b98eb222686ef4fb7f5b0a67ac532f [^]

related to ISSUE-43231: Applied Sonarlint suggestions and finals

Sonarlint suggestions applied.
Finals added.

---
M src/org/openbravo/erpCommon/ad_actionButton/MRPManufacturingPlanProcess.java
---
(0118179)
dmiguelez   
2020-02-27 17:01   
Code Review + Testing Ok