Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043229Retail ModulesWeb POSpublic2020-02-14 19:402020-03-03 15:50
Reporterlbressan 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionRR20Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043229: Cashup model fails to load (full refresh) when having only one payment method as leave as credit
DescriptionWhen having the following configuration, the master data model for the cashup fails to load the Cash Managements.
The problem is that to load the cash management, both GL Items and Financial Accounts related are needed. But if you have only one payment method which does NOT have a Financial Account, the query fails.
The query is executed because GL Items are found (since they are mandatory). Maybe it should not be executed when Financial Accounts for the terminal are not found.
Steps To Reproduce1. Configuration
Have a Touchpoint Type with one Payment Method set as "Leave as Credit".
Have a Touchpoint with only one Payment Type configured, and its Payment Method is the one we set as Leave as Credit (no financial account will be present)

2. Load the terminal for the first time, should be fine.
3. Do a Cashup, log off and clear the cache
4. When reloading the terminal, an error will be shown (attached screenshots):

Error shown to the user:
   Attempted to login using cache but there is not enough data in cache
   ...

Error in log:
ERROR: syntax error at or near ")"
...
at org.openbravo.retail.posterminal.master.Cashup.getCashMgmt(Cashup.java:291)
...


Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Screen Shot 2020-02-14 at 15.38.14.png (670,794) 2020-02-14 19:40
https://issues.openbravo.com/file_download.php?file_id=14049&type=bug
png Screen Shot 2020-02-14 at 15.38.03.png (2,900,717) 2020-02-14 19:41
https://issues.openbravo.com/file_download.php?file_id=14050&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-02-14 19:40lbressanNew Issue
2020-02-14 19:40lbressanAssigned To => Retail
2020-02-14 19:40lbressanFile Added: Screen Shot 2020-02-14 at 15.38.14.png
2020-02-14 19:40lbressanResolution time => 1583449200
2020-02-14 19:40lbressanTriggers an Emergency Pack => No
2020-02-14 19:41lbressanFile Added: Screen Shot 2020-02-14 at 15.38.03.png
2020-02-15 12:52PracticsIssue Monitored: Practics
2020-02-17 14:04ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-02-17 14:04ranjith_qualiantech_comStatusnew => scheduled
2020-02-20 04:23hgbotCheckin
2020-02-20 04:23hgbotNote Added: 0117959
2020-02-20 04:23hgbotStatusscheduled => resolved
2020-02-20 04:23hgbotResolutionopen => fixed
2020-02-20 04:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/582b09e9873a0a747fd38b191ce21eae0e85f036 [^]
2020-03-03 15:50marvintmReview Assigned To => marvintm
2020-03-03 15:50marvintmStatusresolved => closed
2020-03-03 15:50marvintmFixed in Version => RR20Q2

Notes
(0117959)
hgbot   
2020-02-20 04:23   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 582b09e9873a0a747fd38b191ce21eae0e85f036
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Feb 20 08:52:47 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/582b09e9873a0a747fd38b191ce21eae0e85f036 [^]

Fixed issue 43229 : FinAccount should be validated when generating Cashup

* For Terminal with Only one Payment Method (Leave as credit),
  FinAccount will not be available.

---
M src/org/openbravo/retail/posterminal/master/Cashup.java
---