Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043224Openbravo ERPA. Platformpublic2020-02-14 12:232020-02-27 16:48
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043224: Apply new HQL Style in StandardCostAdjustment.java
DescriptionStandardCostAdjustment.java has three HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-02-14 12:23inigo_lergaNew Issue
2020-02-14 12:23inigo_lergaAssigned To => inigo_lerga
2020-02-14 12:23inigo_lergaModules => Core
2020-02-14 12:23inigo_lergaTriggers an Emergency Pack => No
2020-02-17 08:33inigo_lergaStatusnew => scheduled
2020-02-17 10:59inigo_lergaRelationship addedrelated to 0041287
2020-02-27 16:33dmiguelezNote Added: 0118172
2020-02-27 16:47hgbotCheckin
2020-02-27 16:47hgbotNote Added: 0118173
2020-02-27 16:47hgbotStatusscheduled => resolved
2020-02-27 16:47hgbotResolutionopen => fixed
2020-02-27 16:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2474a0e0db979e62328b98af46b5efab88c77287 [^]
2020-02-27 16:47hgbotCheckin
2020-02-27 16:47hgbotNote Added: 0118174
2020-02-27 16:48dmiguelezReview Assigned To => dmiguelez
2020-02-27 16:48dmiguelezNote Added: 0118175
2020-02-27 16:48dmiguelezStatusresolved => closed
2020-02-27 16:48dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0118172)
dmiguelez   
2020-02-27 16:33   
Test plan:

- With Standard Algorithm as the Costing Rule defined for an Organization
- Create a goods receipt for the next month
- Launch the Costing Background Process
- Create an Inventory Amount Update for today and set a different Unit Cost than the one proposed
- Launch the Costing Background Process (some of the queries are executed at this point)
- Create a Purchase Order for today and set a different price for the Product than the Standard Cost
- Create a Goods Receipt for the Purchase Order
- Launch the Costing Background Process (some of the queries are executed at this point)
(0118173)
hgbot   
2020-02-27 16:47   
Repository: erp/devel/pi
Changeset: 2474a0e0db979e62328b98af46b5efab88c77287
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Feb 20 11:34:17 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2474a0e0db979e62328b98af46b5efab88c77287 [^]

fixes BUG-43224:Applied new HQL Style + finals added

---
M src/org/openbravo/costing/StandardAlgorithm.java
M src/org/openbravo/costing/StandardCostAdjustment.java
---
(0118174)
hgbot   
2020-02-27 16:47   
Repository: erp/devel/pi
Changeset: c87dd18743fe694526eaf24395c285ede0fb68e3
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Feb 27 16:41:47 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c87dd18743fe694526eaf24395c285ede0fb68e3 [^]

Related to ISSUE-43224. Code Review Changes:
* Split case when statements in different lines to improve redability
* Added missing formatter:on tag
* Use ids in hql query comparisons instead of objects

---
M src/org/openbravo/costing/StandardCostAdjustment.java
---
(0118175)
dmiguelez   
2020-02-27 16:48   
Code Review + Testing Ok