Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043181Openbravo ERPA. Platformpublic2020-02-10 19:322020-02-19 09:46
Reportershuehner 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q4.2Fixed in Version 
Merge Request Status
Review Assigned Tojarmendariz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2018-10-30
Regression introduced in release3.0PR19Q1
Regression introduced by commithttps://gitlab.com/openbravo/product/dbsm/-/commit/789aa22ca2be4190e5f07a4770c2172e0e5c0552 [^]
Triggers an Emergency PackNo
Summary0043181: Update.database message about local changes in application dictionary is missing table name
DescriptionThe update.database mechanism to check for local changes consists of 2 parts:
a.) structure changes
b.) changes in AD

For part b.) the code did show the table having changes also but is no longer doing so -> Regression.

Checking code of code in dbsm-main repo OBDataset.java method hasChanged:
  if (log != null) {
              log.warn("Change detected in table: " + table.getName());

So issue could be either:
- logger being null (even if seems to be set in OBDBSMOBUtil.java)
- logger being not configured to show by default.
Steps To Reproduce1.) Have clean base (i.e. install.source or previous update.database ran)
2.) Cause local change in AD
update ad_window set updated=now() where ad_window_id = '100';
3.) Run update.database

4.) Check output missing info about table
     [java] 18844 [main] INFO org.openbravo.ddlutils.util.DBSMOBUtil - Checking if database structure was modified locally.
     [java] 19425 [main] INFO org.openbravo.ddlutils.util.DBSMOBUtil - Checking if data has changed in the application dictionary.
     [java] 19465 [main] ERROR org.openbravo.ddlutils.task.AlterDatabaseDataAll - Database has local changes. Update.database will not be done. You should export your changed modules before doing update.database, so that your Application Dictionary changes are preserved.
     [java] Database has local changes. Update.database not done.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0043175 closed alostale Update.database message about local changes in application dictionary is missing table name 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-02-11 10:39alostaleTypedefect => backport
2020-02-11 10:39alostaleTarget Version => 3.0PR19Q4.2
2020-02-13 10:32alostaleTarget Version3.0PR19Q4.2 => 3.0PR20Q4.3
2020-02-18 10:20alostaleNote Added: 0117901
2020-02-18 10:22hgbotCheckin
2020-02-18 10:22hgbotNote Added: 0117903
2020-02-18 10:22hgbotStatusscheduled => resolved
2020-02-18 10:22hgbotResolutionopen => fixed
2020-02-18 10:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q4.2/rev/d26ac45d515a776a26709ce451a0edbcb3ac75ea [^]
2020-02-18 12:47alostaleTarget Version3.0PR20Q4.3 => 3.0PR19Q4.2
2020-02-19 09:46jarmendarizNote Added: 0117938
2020-02-19 09:46jarmendarizStatusresolved => closed

Notes
(0117901)
alostale   
2020-02-18 10:20   
dbsm commit: https://gitlab.com/openbravo/product/dbsm/-/commit/6baf13acc458411bce363f12187c74fab4b462d9 [^]
(0117903)
hgbot   
2020-02-18 10:22   
Repository: erp/backports/3.0PR19Q4.2
Changeset: d26ac45d515a776a26709ce451a0edbcb3ac75ea
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Feb 18 10:19:53 2020 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR19Q4.2/rev/d26ac45d515a776a26709ce451a0edbcb3ac75ea [^]

fixed BUG-43181: AD local changes not logged

  When updating database having local changes in AD, the tables with
  changes were not logged.

  While project to upgrade to log4j2 the API, old API passing old logger
  was kept but it become unusable as null logger was used.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0117938)
jarmendariz   
2020-02-19 09:46   
Reviewed