0043180: Update.database message about local changes in application dictionary is missing table name

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0043180

Openbravo ERP

A. Platform

public

2020-02-10 19:32

2020-04-06 15:45

Reporter

shuehner

Assigned To

alostale

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

3.0PR20Q1

Fixed in Version

Merge Request Status

Review Assigned To

jarmendariz

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Production - Confirmed Stable

Regression date

2018-10-30

Regression introduced in release

3.0PR19Q1

Regression introduced by commit

https://gitlab.com/openbravo/product/dbsm/-/commit/789aa22ca2be4190e5f07a4770c2172e0e5c0552 [^]

Triggers an Emergency Pack

Summary

0043180: Update.database message about local changes in application dictionary is missing table name

Description

The update.database mechanism to check for local changes consists of 2 parts:
a.) structure changes
b.) changes in AD

For part b.) the code did show the table having changes also but is no longer doing so -> Regression.

Checking code of code in dbsm-main repo OBDataset.java method hasChanged:
if (log != null) {
log.warn("Change detected in table: " + table.getName());

So issue could be either:
- logger being null (even if seems to be set in OBDBSMOBUtil.java)
- logger being not configured to show by default.

Steps To Reproduce

1.) Have clean base (i.e. install.source or previous update.database ran)
2.) Cause local change in AD
update ad_window set updated=now() where ad_window_id = '100';
3.) Run update.database

4.) Check output missing info about table
     [java] 18844 [main] INFO org.openbravo.ddlutils.util.DBSMOBUtil - Checking if database structure was modified locally.
     [java] 19425 [main] INFO org.openbravo.ddlutils.util.DBSMOBUtil - Checking if data has changed in the application dictionary.
     [java] 19465 [main] ERROR org.openbravo.ddlutils.task.AlterDatabaseDataAll - Database has local changes. Update.database will not be done. You should export your changed modules before doing update.database, so that your Application Dictionary changes are preserved.
     [java] Database has local changes. Update.database not done.

Proposed Solution

Additional Information