Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043165Retail ModulesWeb POSpublic2020-02-10 16:532020-02-18 07:44
Reportergorka_gil 
Assigned Tomarkmm82 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR19Q4.2Fixed in VersionRR19Q4.2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043165: Before update sources the messages should be synchronized
DescriptionIf exist messages without synchronize, it is needed to send them to the backend before update the webpos sources.
Steps To ReproduceThis issues is especially relevant when message table is moved from websql to indexedDB.

- Having an instance of message table in websql (20q1 or less).
- Go offline and create a ticket.
- Switch the an instance with message table in indexedDB (20q2 or more)
- Go back online.
- Problem: it is updating the sources before synchronize the messages, to these messages will be never synchronize.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0043163 closed gorka_gil Before update sources the messages should be synchronized 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-02-10 16:59gorka_gilTypedefect => backport
2020-02-10 16:59gorka_gilTarget Version => RR19Q4.2
2020-02-13 17:31markmm82Assigned Togorka_gil => markmm82
2020-02-13 17:32hgbotCheckin
2020-02-13 17:32hgbotNote Added: 0117750
2020-02-13 17:32hgbotStatusscheduled => resolved
2020-02-13 17:32hgbotResolutionopen => fixed
2020-02-13 17:32hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR19Q4.2/org.openbravo.mobile.core/rev/a8c9c4aaf9bfd112fd5870d4217931440c2df11c [^]
2020-02-18 07:44guilleaerReview Assigned To => guilleaer
2020-02-18 07:44guilleaerStatusresolved => closed
2020-02-18 07:44guilleaerFixed in Version => RR19Q4.2

Notes
(0117750)
hgbot   
2020-02-13 17:32   
Repository: retail/backports/3.0RR19Q4.2/org.openbravo.mobile.core
Changeset: a8c9c4aaf9bfd112fd5870d4217931440c2df11c
Author: Mark Molina <mark.molina <at> doceleguas.com>
Date: Thu Feb 13 13:24:23 2020 -0300
URL: http://code.openbravo.com/retail/backports/3.0RR19Q4.2/org.openbravo.mobile.core/rev/a8c9c4aaf9bfd112fd5870d4217931440c2df11c [^]

Fixes BUG-43165: Synchronize messages before update sources
- In login, don't update sources if still messages in message table
- Requests of import entry: added call to checkSourceVersion
- Normal requests: it have the sourceVersion, save it in RAM
  for use on import entry request that don't have it:
  OB.UTIL.sourceVersionFromResponse
- When detected the change of source version, force the
  synchronization of messages
   - If fail, show popup and do logout
- Stop logClient synchronization to avoid errors when updating
  because logClient servlet was removed as part of indexedDB change

Also removed error popup on update to allow login offline
If we do login with messages pending to synchronize, in the login process
is forced a syncrhonize of all the messages, but if fails
we don't want to show a popup and do logout, because on innestable
networks will make very dificult the login offline.

---
M web/org.openbravo.mobile.core/source/data/ob-datasource.js
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
---