Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0043151Openbravo ERPA. Platformpublic2020-02-07 13:372020-06-22 11:33
inigo_lerga 
inigo_lerga 
normalminorhave not tried
closedfixed 
5
 
3.0PR20Q2 
dmiguelez
Core
No
0043151: Apply new HQL Style in ResetStockValuation.java
ResetStockValuation.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
-
Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
No tags attached.
related to design defect 0041287 acknowledged platform Tracking issue: Convert HQL to apply new style 
Issue History
2020-02-07 13:37inigo_lergaNew Issue
2020-02-07 13:37inigo_lergaAssigned To => inigo_lerga
2020-02-07 13:37inigo_lergaModules => Core
2020-02-07 13:37inigo_lergaTriggers an Emergency Pack => No
2020-02-13 13:47inigo_lergaStatusnew => scheduled
2020-02-14 13:57inigo_lergaNote Added: 0117809
2020-02-27 12:55hgbotCheckin
2020-02-27 12:55hgbotNote Added: 0118155
2020-02-27 12:55hgbotStatusscheduled => resolved
2020-02-27 12:55hgbotResolutionopen => fixed
2020-02-27 12:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2af9d85febef5dadbe9f13af22f1889f34c46323 [^]
2020-02-27 12:55hgbotCheckin
2020-02-27 12:55hgbotNote Added: 0118156
2020-02-27 12:56dmiguelezReview Assigned To => dmiguelez
2020-02-27 12:56dmiguelezNote Added: 0118157
2020-02-27 12:56dmiguelezStatusresolved => closed
2020-02-27 12:56dmiguelezFixed in Version => 3.0PR20Q2
2020-06-22 11:33inigo_lergaRelationship addedrelated to 0041287

Notes
(0117809)
inigo_lerga   
2020-02-14 13:57   
--Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
    - Go to the Reset Unit Cost window and select any Organization.
      Press the Done Button.

    #In this moment another modified HQLs are executed#
(0118155)
hgbot   
2020-02-27 12:55   
Repository: erp/devel/pi
Changeset: 2af9d85febef5dadbe9f13af22f1889f34c46323
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Feb 13 17:33:34 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2af9d85febef5dadbe9f13af22f1889f34c46323 [^]

fixes BUG-43151:Applied new HQL Style + license msg added

---
M src/org/openbravo/costing/ResetStockValuation.java
---
(0118156)
hgbot   
2020-02-27 12:55   
Repository: erp/devel/pi
Changeset: 039bcab72e6dfa6801150c45ea2e10c4d36fcc6a
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri Feb 14 13:42:37 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/039bcab72e6dfa6801150c45ea2e10c4d36fcc6a [^]

related to ISSUE-43151: Applied Sonarlint suggestions and more

Sonarlint suggestions applied.
Finals added.
HQL query updated with current format.
getResponseBuilder used when available to send messages.

---
M src/org/openbravo/costing/ResetStockValuation.java
---
(0118157)
dmiguelez   
2020-02-27 12:56   
Code Review + Testing Ok