Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043113Retail ModulesWeb POSpublic2020-02-04 12:572020-03-03 12:33
Reportermalsasua 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket14497
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043113: In terminals without payments defined, the layaways amounts are not included in any cashup report
DescriptionThe layaway amount is included in the sales amount cashup where the layaway is created.

If a terminal is configured without payment methods, it is not possible to complete a cashup. So, the layaways created in this terminal never are included in a cashup report.
Steps To ReproduceBO:
. create a new terminal (T1) in White Valley without payment methods

POS:
. login in T1
. new sales order (SO1):
 - add line Avalanche Receiver: total ticket 150.50
. complete SO1 clicking in "layaway" button -> Layaway is synced
. go to Menu-> cashup option is not displayed

POS:
. login in VBS-1
. load layaway SO1
. click in total button
. add payment: Cash 150.50 -> SO1 is completed and synced
. go to Menu -> cashup:
 - total sales: 0
 - Cash payment method amount: 150.50

Problem: the sale of 150.50 never is included in a cashup report, but the payment is included in the cashup report when the payment is done
Proposed SolutionOriginal proposed solution from support
-----------------------------------
It should be possible to do cashups in terminals without payment methos

Proposed solution from Retail Team
-----------------------------------
Create a configuration field in organization/store to decide if layaways will be treated as a sale when they are created or when they are completed.
Following this model, layaways (at the end sales) will be included in the cashup report of the terminal where it is closed.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-02-04 12:57malsasuaNew Issue
2020-02-04 12:57malsasuaAssigned To => Retail
2020-02-04 12:57malsasuaOBNetwork customer => Gold
2020-02-04 12:57malsasuaSupport ticket => 14497
2020-02-04 12:57malsasuaResolution time => 1582585200
2020-02-04 12:57malsasuaTriggers an Emergency Pack => No
2020-02-04 13:38ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-02-04 17:22guilleaerProposed Solution updated
2020-02-05 06:50ranjith_qualiantech_comStatusnew => scheduled
2020-02-06 11:48guilleaerProposed Solution updated
2020-02-11 15:13hgbotCheckin
2020-02-11 15:13hgbotNote Added: 0117642
2020-02-11 15:13hgbotStatusscheduled => resolved
2020-02-11 15:13hgbotResolutionopen => fixed
2020-02-11 15:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e67410f91e3594f4bfe7e79bf08531fec91f61da [^]
2020-02-12 07:05hgbotCheckin
2020-02-12 07:05hgbotNote Added: 0117665
2020-02-12 07:05hgbotCheckin
2020-02-12 07:05hgbotNote Added: 0117666
2020-02-12 07:08ranjith_qualiantech_comNote Added: 0117667
2020-02-12 08:14hgbotCheckin
2020-02-12 08:14hgbotNote Added: 0117668
2020-02-14 19:52guilleaerReview Assigned To => marvintm
2020-02-28 11:13marvintmNote Added: 0118198
2020-02-28 11:13marvintmStatusresolved => new
2020-02-28 11:13marvintmResolutionfixed => open
2020-03-01 06:15ranjith_qualiantech_comStatusnew => scheduled
2020-03-01 06:19hgbotCheckin
2020-03-01 06:19hgbotNote Added: 0118214
2020-03-01 06:19hgbotStatusscheduled => resolved
2020-03-01 06:19hgbotResolutionopen => fixed
2020-03-01 06:19hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e67410f91e3594f4bfe7e79bf08531fec91f61da [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1668fa40e62bec4f445fe3cadafeffacd8816455 [^]
2020-03-01 06:20hgbotCheckin
2020-03-01 06:20hgbotNote Added: 0118215
2020-03-03 12:33marvintmStatusresolved => closed
2020-03-03 12:33marvintmFixed in Version => RR20Q2

Notes
(0117642)
hgbot   
2020-02-11 15:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e67410f91e3594f4bfe7e79bf08531fec91f61da
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Feb 11 19:42:17 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e67410f91e3594f4bfe7e79bf08531fec91f61da [^]

Fixed issue 43113 : Added Validation to Count Layaways as Sales

* Added New column in Org "Count Layaways as Sales" with default value as true
  If the value is true, when completing the layaway, it will consider as sales
  else it will consider as sales only when layaway is fully paid

---
M src-db/database/model/modifiedTables/AD_ORG.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/retail/posterminal/term/TerminalProperties.java
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0117665)
hgbot   
2020-02-12 07:05   
Repository: erp/pmods/org.openbravo.retail.testsampledata
Changeset: 974e23c0ce5112f4ea690370c7cf17650ac0df33
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Feb 12 11:34:47 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.testsampledata/rev/974e23c0ce5112f4ea690370c7cf17650ac0df33 [^]

Related to issue 43113 : Updated Sample Data for new Column in Org Table

---
M referencedata/sampledata/Retail_Test/AD_ORG.xml
---
(0117666)
hgbot   
2020-02-12 07:05   
Repository: tools/automation/pi-mobile
Changeset: a16c414d0030f203de1907982d4b84398225bdea
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Feb 12 11:35:40 2020 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a16c414d0030f203de1907982d4b84398225bdea [^]

Verifies issue 43113 : Added Automated test 'I43113_VerifyCountLayawayAsSales'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I43113_VerifyCountLayawayAsSales.java
---
(0117667)
ranjith_qualiantech_com   
2020-02-12 07:08   
Repository: erp/pmods-branches/org.openbravo.test.mobile.sampledata
Changeset: 663afc40a477
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Feb 12 11:34:47 2020 +0530
URL: https://code.openbravo.com/erp/pmods-branches/org.openbravo.test.mobile.sampledata/rev/663afc40a477 [^] [^]

Related to issue 43113 : Updated Sample Data for new Column in Org Table

---
M referencedata/sampledata/The_White_Valley_Group/AD_ORG.xml
(0117668)
hgbot   
2020-02-12 08:14   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 402fd704e4c36959d23bafc967a4b21380272819
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Feb 12 12:44:16 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/402fd704e4c36959d23bafc967a4b21380272819 [^]

Related to issue 43113 : Updated Sample Data for new Column in Org Table

---
M referencedata/sampledata/The_White_Valley_Group/AD_ORG.xml
---
(0118198)
marvintm   
2020-02-28 11:13   
I'm facing a problem. Cases when store is marked as "count layaways as sales" are working fine.

However, when I mark the store as "do not count layaways as sales", normal sales are also not counted.

So for example if I uncheck the flag, and then do a normal ticket and pay it in full, it is not counted as sale. This is not correct.
(0118214)
hgbot   
2020-03-01 06:19   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1668fa40e62bec4f445fe3cadafeffacd8816455
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sun Mar 01 10:48:50 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1668fa40e62bec4f445fe3cadafeffacd8816455 [^]

Fixed ISSUE-43113 : Added Validation to Count Layaways as Sales

* If the value is true, when completing the layaway with/without payment,
  it will consider as sales
* Else it will consider as sales only when layaway is fully paid

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0118215)
hgbot   
2020-03-01 06:20   
Repository: tools/automation/pi-mobile
Changeset: 59e52c27b994d7df5f8aab95d5b2978d6453e9d2
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sun Mar 01 10:49:59 2020 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/59e52c27b994d7df5f8aab95d5b2978d6453e9d2 [^]

Verifies ISSUE-43113 : Modified Test 'I43113_VerifyCountLayawayAsSales'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I43113_VerifyCountLayawayAsSales.java
---