Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043099Openbravo ERPA. Platformpublic2020-02-03 12:272020-02-07 13:29
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043099: Apply new HQL Style in InventoryAmountUpdateProcess.java
DescriptionInventoryAmountUpdateProcess.java has 3 HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-02-03 12:27inigo_lergaNew Issue
2020-02-03 12:27inigo_lergaAssigned To => platform
2020-02-03 12:27inigo_lergaOBNetwork customer => No
2020-02-03 12:27inigo_lergaModules => Core
2020-02-03 12:27inigo_lergaTriggers an Emergency Pack => No
2020-02-03 12:27inigo_lergaAssigned Toplatform => inigo_lerga
2020-02-03 12:27inigo_lergaStatusnew => scheduled
2020-02-03 12:28inigo_lergaRelationship addedrelated to 0041287
2020-02-03 14:23inigo_lergaNote Added: 0117430
2020-02-07 13:28hgbotCheckin
2020-02-07 13:28hgbotNote Added: 0117567
2020-02-07 13:28hgbotStatusscheduled => resolved
2020-02-07 13:28hgbotResolutionopen => fixed
2020-02-07 13:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/acfc762fe329f9a89ce2e70cc2e2bf71dd4ec66e [^]
2020-02-07 13:28hgbotCheckin
2020-02-07 13:28hgbotNote Added: 0117568
2020-02-07 13:28hgbotCheckin
2020-02-07 13:28hgbotNote Added: 0117569
2020-02-07 13:29dmiguelezReview Assigned To => dmiguelez
2020-02-07 13:29dmiguelezNote Added: 0117570
2020-02-07 13:29dmiguelezStatusresolved => closed
2020-02-07 13:29dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0117430)
inigo_lerga   
2020-02-03 14:23   
Test Plan Mantis HQL queries:
As the F&B International Group Admin role:
    - Go to the Inventory Amount Update window and
      create a new record. Leave every field as default.
    - Save the record.
    - Go to the Lines Tab and create a new record with
      "Cerveza Ale 0,5L" as Product. Leave every other
      field as default.
    - Save the record.
    - Press the Process button and Done button in the popup
      window.
    #In this moment modified HQLs are executed#
(0117567)
hgbot   
2020-02-07 13:28   
Repository: erp/devel/pi
Changeset: acfc762fe329f9a89ce2e70cc2e2bf71dd4ec66e
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Feb 03 16:28:24 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/acfc762fe329f9a89ce2e70cc2e2bf71dd4ec66e [^]

fixes BUG-43099:Applied new HQL Style

---
M src/org/openbravo/costing/InventoryAmountUpdateProcess.java
---
(0117568)
hgbot   
2020-02-07 13:28   
Repository: erp/devel/pi
Changeset: e2afe6eb1f2e50d287120ab54834422baf2754fa
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Feb 03 16:52:07 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e2afe6eb1f2e50d287120ab54834422baf2754fa [^]

related to ISSUE-43099: Applied Sonarlint suggestions

---
M src/org/openbravo/costing/InventoryAmountUpdateProcess.java
---
(0117569)
hgbot   
2020-02-07 13:28   
Repository: erp/devel/pi
Changeset: 1023e25134e1c2a7d0b36ae5fccb0510c1ac9175
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Feb 07 13:28:26 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1023e25134e1c2a7d0b36ae5fccb0510c1ac9175 [^]

Related to ISSUE-43099: Code Review changes
* Use ids instead of objects in hql query
* Changed names of variables to better reflect
  that they refer to ids

---
M src/org/openbravo/costing/InventoryAmountUpdateProcess.java
---
(0117570)
dmiguelez   
2020-02-07 13:29   
Code Review + Testing Ok