Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0043097Openbravo ERPA. Platformpublic2020-02-03 12:162020-02-07 12:44
inigo_lerga 
inigo_lerga 
normalminorhave not tried
closedfixed 
5
 
 
dmiguelez
Core
No
0043097: Apply new HQL Style in FixBackdatedTransactionsProcess.java
FixBackdatedTransactionsProcess.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
-
Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
No tags attached.
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Issue History
2020-02-03 12:16inigo_lergaNew Issue
2020-02-03 12:16inigo_lergaAssigned To => inigo_lerga
2020-02-03 12:16inigo_lergaModules => Core
2020-02-03 12:16inigo_lergaTriggers an Emergency Pack => No
2020-02-03 12:17inigo_lergaStatusnew => acknowledged
2020-02-03 12:17inigo_lergaDescription Updatedbug_revision_view_page.php?rev_id=20278#r20278
2020-02-03 12:17inigo_lergaStatusacknowledged => scheduled
2020-02-03 12:17inigo_lergaRelationship addedrelated to 0041287
2020-02-03 13:02inigo_lergaNote Added: 0117429
2020-02-07 12:43hgbotCheckin
2020-02-07 12:43hgbotNote Added: 0117563
2020-02-07 12:43hgbotStatusscheduled => resolved
2020-02-07 12:43hgbotResolutionopen => fixed
2020-02-07 12:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f9730e18aba5ee5fb55e36bf91f4096a8544104d [^]
2020-02-07 12:43hgbotCheckin
2020-02-07 12:43hgbotNote Added: 0117564
2020-02-07 12:44dmiguelezReview Assigned To => dmiguelez
2020-02-07 12:44dmiguelezNote Added: 0117565
2020-02-07 12:44dmiguelezStatusresolved => closed

Notes
(0117429)
inigo_lerga   
2020-02-03 13:02   
Test Plan Mantis HQL queries:
As the F&B International Group Admin role:
    - Go to the Costing Rules window and select
      the one with "F&B US, Inc." as organization.
      Press the Fix Backdated Transactions button
      and Done button.
    #In this moment the middle modified HQL is executed#
(0117563)
hgbot   
2020-02-07 12:43   
Repository: erp/devel/pi
Changeset: f9730e18aba5ee5fb55e36bf91f4096a8544104d
Author: IƱigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Feb 03 13:19:32 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f9730e18aba5ee5fb55e36bf91f4096a8544104d [^]

fixes BUG-43097:Applied new HQL Style + final added

---
M src/org/openbravo/costing/FixBackdatedTransactionsProcess.java
---
(0117564)
hgbot   
2020-02-07 12:43   
Repository: erp/devel/pi
Changeset: 940471140131062ecb0a4cbda8c90206c8bda20d
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Feb 07 12:43:28 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/940471140131062ecb0a4cbda8c90206c8bda20d [^]

Related to ISSUE-43097. Changed variable name to better reflect
that is a list of ids

---
M src/org/openbravo/costing/FixBackdatedTransactionsProcess.java
---
(0117565)
dmiguelez   
2020-02-07 12:44   
Code Review + Testing Ok