Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043088Retail ModulesWeb POSpublic2020-02-02 20:452020-02-19 13:07
Reporterasiermartirena 
Assigned Toprakashmurugesan88 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043088: Prepayments are not being correctly managed in Pay Open Tickets
DescriptionUsing prepayments and pay open tickets, the prepayments are not being correctly calculated when that prepayment calculation has an asynchronous process. In addition, the calculation is being raised many times for each order.
Steps To ReproduceNot reproducible with the current prepayments algorithm in the Web POS. It could be reproduced, for example, with the algorithm created for BUT.
Proposed SolutionCall the method to calculate the prepayments in Pay Open Tickets having into account a possible asynchronous process.
Avoid also to call the process each time an order is added to the multiorder collection or when resetting the collection. Instead, call once all the orders have been added.
Additional Information
TagsNo tags attached.
Relationships
Attached Files? issue_43088.export (8,619) 2020-02-07 14:22
https://issues.openbravo.com/file_download.php?file_id=13986&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-02-02 20:45asiermartirenaNew Issue
2020-02-02 20:45asiermartirenaAssigned To => asiermartirena
2020-02-02 20:45asiermartirenaOBNetwork customer => Gold
2020-02-02 20:45asiermartirenaTriggers an Emergency Pack => No
2020-02-07 14:22asiermartirenaFile Added: issue_43088.export
2020-02-07 14:26asiermartirenaAssigned Toasiermartirena => prakashmurugesan88
2020-02-11 14:01hgbotCheckin
2020-02-11 14:01hgbotNote Added: 0117638
2020-02-11 14:01hgbotStatusnew => resolved
2020-02-11 14:01hgbotResolutionopen => fixed
2020-02-11 14:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/04ece4ec0bbc4bfff741222e18bf5a3595c5dcbe [^]
2020-02-11 14:01hgbotCheckin
2020-02-11 14:01hgbotNote Added: 0117639
2020-02-19 13:07guilleaerReview Assigned To => guilleaer
2020-02-19 13:07guilleaerStatusresolved => closed
2020-02-19 13:07guilleaerFixed in Version => RR20Q2

Notes
(0117638)
hgbot   
2020-02-11 14:01   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 04ece4ec0bbc4bfff741222e18bf5a3595c5dcbe
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Tue Feb 11 18:29:25 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/04ece4ec0bbc4bfff741222e18bf5a3595c5dcbe [^]

Fixed issue 43088: Manage asynchrony in pay open tickets when calculating prepayments

Modified the way to calculate the prepayments in the pay open tickets flow, to be able to manage correctly in the case the prepayments calculation algorithm has asynchrony.
In addition, changes done to avoid to call the calculation many times for each order.

---
M web/org.openbravo.retail.posterminal/js/components/modal-pay-open-tickets.js
M web/org.openbravo.retail.posterminal/js/components/order.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0117639)
hgbot   
2020-02-11 14:01   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 603c4ae0e05befa20bbd1a9c01d2e8e80dd08261
Author: Prakash M <prakash <at> qualiantech.com>
Date: Tue Feb 11 18:29:25 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/603c4ae0e05befa20bbd1a9c01d2e8e80dd08261 [^]

Related to issue 43088: Fixed following issue in Pay Open Ticket

* Opened ticket lost on reload
* Added payment lost on reload

---
M web/org.openbravo.retail.posterminal/js/components/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---