0043078: don't download files with a POST to a hidden form

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0043078

Openbravo ERP

A. Platform

public

2020-01-31 10:24

2022-02-01 08:07

Reporter

alostale

Assigned To

Triage Platform Base

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

acknowledged

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0043078: don't download files with a POST to a hidden form

Description

Currently backoffice downloads (ie. csv export, pdf reports, etc...) are implemented as a POST request through a hidden form see (OB.Utilities.postThroughHiddenForm).

This has some incovenients:
* Can't handle errors properly: if the request fails, the error cannot be intercepted
* Because of that reason, PDF export requires 2 requests: 1 to generate the report and check if it failed, another one to perform the actual download

We should reimplement this piece to perform an ajax fetch and handling properly the response.

See:
https://gitlab.com/openbravo/product/openbravo/snippets/1934905 [^]
https://developer.mozilla.org/en-US/docs/Web/API/Streams_API/Using_readable_streams [^]

Steps To Reproduce

Proposed Solution

Additional Information