Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043061Openbravo ERPA. Platformpublic2020-01-30 09:452020-02-07 11:06
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043061: Private functions not locally used in CostingAlgorithmAdjustmentImp.java
DescriptionThere are two private functions in the CostingAlgorithmAdjustmentImp.java script, which are not used locally and, therefore, nowhere else.
Steps To Reproduce-
Proposed SolutionDelete the following functions:

inventoryHasCost(final CostAdjustmentLine costAdjLine)
hasReturnedReceipt(final CostAdjustmentLine costAdjLine)
Additional Information
TagsNo tags attached.
Relationships
related to defect 0043044 closed inigo_lerga Apply new HQL Style in CostingAlgorithmAdjustmentImp.java 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-30 09:45inigo_lergaNew Issue
2020-01-30 09:45inigo_lergaAssigned To => inigo_lerga
2020-01-30 09:45inigo_lergaOBNetwork customer => No
2020-01-30 09:45inigo_lergaModules => Core
2020-01-30 09:45inigo_lergaTriggers an Emergency Pack => No
2020-01-30 09:45inigo_lergaStatusnew => scheduled
2020-01-30 09:49inigo_lergaRelationship addedrelated to 0043044
2020-02-07 11:05hgbotCheckin
2020-02-07 11:05hgbotNote Added: 0117551
2020-02-07 11:05hgbotStatusscheduled => resolved
2020-02-07 11:05hgbotResolutionopen => fixed
2020-02-07 11:05hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e1394ac92b281fe91ea727e183384b7507d16a4d [^]
2020-02-07 11:06dmiguelezReview Assigned To => dmiguelez
2020-02-07 11:06dmiguelezNote Added: 0117552
2020-02-07 11:06dmiguelezStatusresolved => closed
2020-02-07 11:06dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0117551)
hgbot   
2020-02-07 11:05   
Repository: erp/devel/pi
Changeset: e1394ac92b281fe91ea727e183384b7507d16a4d
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Jan 30 09:54:10 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e1394ac92b281fe91ea727e183384b7507d16a4d [^]

fixes BUG-43061:Deleted private functions not locally used

Deleted the following functions:
inventoryHasCost(final CostAdjustmentLine costAdjLine)
hasReturnedReceipt(final CostAdjustmentLine costAdjLine)

---
M src/org/openbravo/costing/CostingAlgorithmAdjustmentImp.java
---
(0117552)
dmiguelez   
2020-02-07 11:06   
Code Review + Testing Ok