Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043051Openbravo ERPA. Platformpublic2020-01-29 16:222020-02-07 11:33
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043051: Apply new HQL Style in CostingRuleProcessOnProcessHandler.java
DescriptionCostingRuleProcessOnProcessHandler.java has 2 HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-29 16:22inigo_lergaNew Issue
2020-01-29 16:22inigo_lergaAssigned To => inigo_lerga
2020-01-29 16:22inigo_lergaModules => Core
2020-01-29 16:22inigo_lergaTriggers an Emergency Pack => No
2020-01-29 16:22inigo_lergaRelationship addedrelated to 0041287
2020-01-29 16:23inigo_lergaStatusnew => scheduled
2020-01-30 12:16inigo_lergaNote Added: 0117365
2020-02-07 11:32hgbotCheckin
2020-02-07 11:32hgbotNote Added: 0117553
2020-02-07 11:32hgbotStatusscheduled => resolved
2020-02-07 11:32hgbotResolutionopen => fixed
2020-02-07 11:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bfcc801da2e8e663531c7f875c69a8dd962cea99 [^]
2020-02-07 11:32hgbotCheckin
2020-02-07 11:32hgbotNote Added: 0117554
2020-02-07 11:33dmiguelezReview Assigned To => dmiguelez
2020-02-07 11:33dmiguelezNote Added: 0117555
2020-02-07 11:33dmiguelezStatusresolved => closed
2020-02-07 11:33dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0117365)
inigo_lerga   
2020-01-30 12:16   
Test Plan Mantis HQL queries:
As the F&B International Group Admin role:
    - Go to the Costing Rules window and create a new
      record with all fields as default. Save and press
      the Validate Costing Rule button and then Done
      button in the popup window.
    #In this moment the modified HQLs are executed#
(0117553)
hgbot   
2020-02-07 11:32   
Repository: erp/devel/pi
Changeset: bfcc801da2e8e663531c7f875c69a8dd962cea99
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Jan 30 12:10:00 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/bfcc801da2e8e663531c7f875c69a8dd962cea99 [^]

fixes BUG-43051:Applied new HQL Style + finals added

---
M src/org/openbravo/costing/CostingRuleProcessOnProcessHandler.java
---
(0117554)
hgbot   
2020-02-07 11:32   
Repository: erp/devel/pi
Changeset: a917cf43f5c879a830e3f559bbd056e8b9eaa1c4
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Feb 07 11:32:08 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a917cf43f5c879a830e3f559bbd056e8b9eaa1c4 [^]

Related to ISSUE-43051. Code Review changes:
* Use id's instead of objects in hql queries
* Changed variable names to better reflect that they
  refer to an id.

---
M src/org/openbravo/costing/CostingRuleProcessOnProcessHandler.java
---
(0117555)
dmiguelez   
2020-02-07 11:33   
Code Review + Testing Ok