Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043038Retail ModulesWeb POSpublic2020-01-28 16:512020-01-31 09:05
Reporterbarbararoncato 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043038: The preference "Web POS Select Printer" doesn't work.
DescriptionIf the preference "Web POS Select Printer" is set to = N, it doesn't hide the options "Select Printer" and "Select PDF Printer" from the menu in WebPOS.
Steps To ReproduceCASE 1

Preconditions:
- In Channel Touchpoint Type, uncheck the flag "Select Printer Always" for terminal VBS-1.
- Configure the preference "Web POS Select Printer" as N for a manual role(Cashier Vallblanca in livebuilds retail with module).

Steps:
1. Login to WebPOS VBS-1 terminal, with the role from step 2.
-> The option "Select Printer" is still visible but when you click on it nothing happens (with an automatic role it works)


CASE 2:

Preconditions:
- In Channel Touchpoint Type, check the flag "Select Printer Always" for terminal VBS-1.
- Configure the preference "Web POS Select Printer" as N for a manual role(Cashier Vallblanca in livebuilds retail with module).

Steps:
1. Login to WebPOS with the role from step 2.
-> The option "Select Printer" is hidden.

summary:
Preference value does not affect to the visibility on the menu but makes the click action work or not.
The logic to show or not the menu entry is based on the value of the flag "Select Printer Always" of Touchpoint Type

current code to manage display logic

displayLogic: function() {
if (
!OB.MobileApp.model.get('terminal').terminalType.selectprinteralways &&
_.any(OB.POS.modelterminal.get('hardwareURL'), function(printer) {
return printer.hasReceiptPrinter;
})
) {
this.show();
} else {
this.hide();
}
}
Proposed SolutionWork as other menu entries.
If preference is N -> Not show
If preference is enabled or is a manual role -> Show

If (show == true) {
  if (appropiate configuration) {
     Show
  }
}

To achieve above behavior we will transform the menu entry into an Action

Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-28 16:51barbararoncatoNew Issue
2020-01-28 16:51barbararoncatoAssigned To => Retail
2020-01-28 16:51barbararoncatoOBNetwork customer => Gold
2020-01-28 16:51barbararoncatoResolution time => 1580511600
2020-01-28 16:51barbararoncatoTriggers an Emergency Pack => No
2020-01-29 15:19rqueraltaAssigned ToRetail => rqueralta
2020-01-29 17:14barbararoncatoDescription Updatedbug_revision_view_page.php?rev_id=20256#r20256
2020-01-29 17:14barbararoncatoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=20258#r20258
2020-01-29 18:09guilleaerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=20259#r20259
2020-01-29 18:09guilleaerProposed Solution updated
2020-01-30 10:41guilleaerProposed Solution updated
2020-01-30 10:43ranjith_qualiantech_comAssigned Torqueralta => ranjith_qualiantech_com
2020-01-30 10:43ranjith_qualiantech_comStatusnew => scheduled
2020-01-31 06:54hgbotCheckin
2020-01-31 06:54hgbotNote Added: 0117386
2020-01-31 06:54hgbotStatusscheduled => resolved
2020-01-31 06:54hgbotResolutionopen => fixed
2020-01-31 06:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb963f9926c5b7cf0be8f805f6297ba55e4bd1eb [^]
2020-01-31 09:05guilleaerReview Assigned To => guilleaer
2020-01-31 09:05guilleaerStatusresolved => closed
2020-01-31 09:05guilleaerFixed in Version => RR20Q2

Notes
(0117386)
hgbot   
2020-01-31 06:54   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: eb963f9926c5b7cf0be8f805f6297ba55e4bd1eb
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jan 31 11:24:36 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb963f9926c5b7cf0be8f805f6297ba55e4bd1eb [^]

Fixed issue 43038 : Added ActionCommand for SelectPrinter and SelectPDFPrinter Menu

---
M src-db/database/sourcedata/OBMOBC_ACTION.xml
M src-db/database/sourcedata/OBMOBC_ACTION_CTYPE.xml
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/js/components/menu.js
A web/org.openbravo.retail.posterminal/js/actions/selectpdfprinter.js
A web/org.openbravo.retail.posterminal/js/actions/selectprinter.js
---