Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043034Openbravo ERPA. Platformpublic2020-01-28 12:472020-02-07 09:57
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043034: Apply new HQL Style in CostingAlgorithm.java
DescriptionCostingAlgorithm.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-28 12:47inigo_lergaNew Issue
2020-01-28 12:47inigo_lergaAssigned To => inigo_lerga
2020-01-28 12:47inigo_lergaModules => Core
2020-01-28 12:47inigo_lergaTriggers an Emergency Pack => No
2020-01-28 12:47inigo_lergaRelationship addedrelated to 0041287
2020-01-29 11:03inigo_lergaStatusnew => scheduled
2020-01-29 14:48inigo_lergaNote Added: 0117323
2020-02-07 09:55hgbotCheckin
2020-02-07 09:55hgbotNote Added: 0117541
2020-02-07 09:55hgbotStatusscheduled => resolved
2020-02-07 09:55hgbotResolutionopen => fixed
2020-02-07 09:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/54a2a3c9a91c055916bb19c5c997a9bfb03890ec [^]
2020-02-07 09:55hgbotCheckin
2020-02-07 09:55hgbotNote Added: 0117542
2020-02-07 09:57dmiguelezReview Assigned To => dmiguelez
2020-02-07 09:57dmiguelezNote Added: 0117543
2020-02-07 09:57dmiguelezStatusresolved => closed
2020-02-07 09:57dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0117323)
inigo_lerga   
2020-01-29 14:48   
Test Plan Mantis HQL queries:
Execute the TestCosting.java JUnit tests.
#In this moment all the modified HQLs are executed#
(0117541)
hgbot   
2020-02-07 09:55   
Repository: erp/devel/pi
Changeset: 54a2a3c9a91c055916bb19c5c997a9bfb03890ec
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Jan 29 14:45:42 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/54a2a3c9a91c055916bb19c5c997a9bfb03890ec [^]

fixes BUG-43034:Applied new HQL Style + finals added

---
M src/org/openbravo/costing/CostingAlgorithm.java
---
(0117542)
hgbot   
2020-02-07 09:55   
Repository: erp/devel/pi
Changeset: 77248fdacecb2449319fa0248d75bd778a6247a7
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Feb 07 09:55:14 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/77248fdacecb2449319fa0248d75bd778a6247a7 [^]

Related to ISSUE-43034. Code Review changes:
* Renamed variables to make more obvious that they are referring to Id's and
  not to the object itself
* Added final modifier

---
M src/org/openbravo/costing/CostingAlgorithm.java
---
(0117543)
dmiguelez   
2020-02-07 09:57   
Code Review + Testing Ok