Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043029Openbravo ERPA. Platformpublic2020-01-28 12:232020-02-13 12:05
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043029: export to csv doesn't timeout
DescriptionHaving db.queryTimeout.grid configured, queries to generate CSV don't timeout.
Steps To Reproduce1. define db.queryTimeout.grid=1
2. export a csv that takes more than 1 sec to generate the query
Proposed SolutionApply db.queryTimeout.grid to csv export.

Note that ideally, UI should notify about this error.

Note DefaultJsonDataService.fetch(Map<String, String> parameters, QueryResultWriter writer) method is also used by JSON webservices.
Additional Information
TagsPerformance
Relationships
depends on backport 00432063.0PR20Q1 closed alostale export to csv doesn't timeout 
depends on backport 00432073.0PR19Q4.2 closed alostale export to csv doesn't timeout 
depends on backport 00432083.0PR19Q3.4 closed alostale export to csv doesn't timeout 
related to defect 0043030 closed alostale csv button enabled while editing filters with lazy fitlering enabled 
related to feature request 0043078 acknowledged Triage Platform Base don't download files with a POST to a hidden form 
blocks design defect 0043031 acknowledged Triage Platform Base implement a timeout for CSV generation 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-28 12:23alostaleNew Issue
2020-01-28 12:23alostaleAssigned To => platform
2020-01-28 12:23alostaleModules => Core
2020-01-28 12:23alostaleTriggers an Emergency Pack => No
2020-01-28 12:24alostaleTag Attached: Performance
2020-01-28 12:29alostaleRelationship addedrelated to 0043030
2020-01-28 12:30alostaleProposed Solution updated
2020-01-28 12:34alostaleRelationship addedblocks 0043031
2020-01-28 13:15alostaleProposed Solution updated
2020-01-28 13:17ioritzCiaResolution time => 1583017200
2020-01-28 13:22ioritzCiaIssue Monitored: ioritzCia
2020-01-30 15:30alostaleNote Added: 0117372
2020-01-31 10:27alostaleRelationship addedrelated to 0043078
2020-02-13 09:23hgbotCheckin
2020-02-13 09:23hgbotNote Added: 0117718
2020-02-13 09:23hgbotStatusnew => resolved
2020-02-13 09:23hgbotResolutionopen => fixed
2020-02-13 09:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1d19e9db807746db520f34f622102f6b2f7a1249 [^]
2020-02-13 09:23alostaleAssigned Toplatform => alostale
2020-02-13 09:24alostaleReview Assigned To => caristu
2020-02-13 09:26alostaleStatusresolved => new
2020-02-13 09:26alostaleResolutionfixed => open
2020-02-13 09:27alostaleStatusnew => scheduled
2020-02-13 09:27alostaleStatusscheduled => resolved
2020-02-13 09:27alostaleResolutionopen => fixed
2020-02-13 09:29alostaleSeveritymajor => critical
2020-02-13 12:05caristuNote Added: 0117727
2020-02-13 12:05caristuStatusresolved => closed
2020-02-13 12:05caristuFixed in Version => 3.0PR20Q2

Notes
(0117372)
alostale   
2020-01-30 15:30   
MR: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/38 [^]
(0117718)
hgbot   
2020-02-13 09:23   
Repository: erp/devel/pi
Changeset: 1d19e9db807746db520f34f622102f6b2f7a1249
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jan 28 13:25:57 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1d19e9db807746db520f34f622102f6b2f7a1249 [^]

fixed BUG-43029: export to csv doesn't timeout

  Apply grid timeout to CSV export.

  Moved timeout profile setting to a more generic part, before it was
  applied only for the query to populate the grid, but it should be for
  every one.

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
---
(0117727)
caristu   
2020-02-13 12:05   
Reviewed + tested OK