Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043008Openbravo ERPA. Platformpublic2020-01-27 11:012020-02-26 16:58
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043008: Apply new HQL Style in CostAdjustmentUtils.java
DescriptionCostAdjustmentUtils.java has 12 HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-27 11:01inigo_lergaNew Issue
2020-01-27 11:01inigo_lergaAssigned To => inigo_lerga
2020-01-27 11:01inigo_lergaOBNetwork customer => No
2020-01-27 11:01inigo_lergaModules => Core
2020-01-27 11:01inigo_lergaTriggers an Emergency Pack => No
2020-01-27 11:01inigo_lergaStatusnew => scheduled
2020-01-27 11:01inigo_lergaRelationship addedrelated to 0041287
2020-02-20 10:12inigo_lergaNote Added: 0117960
2020-02-26 16:58hgbotCheckin
2020-02-26 16:58hgbotNote Added: 0118122
2020-02-26 16:58hgbotStatusscheduled => resolved
2020-02-26 16:58hgbotResolutionopen => fixed
2020-02-26 16:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a0f6363a98c186c45aba6c28b067ca8ec64b6d0e [^]
2020-02-26 16:58hgbotCheckin
2020-02-26 16:58hgbotNote Added: 0118123
2020-02-26 16:58dmiguelezReview Assigned To => dmiguelez
2020-02-26 16:58dmiguelezNote Added: 0118124
2020-02-26 16:58dmiguelezStatusresolved => closed
2020-02-26 16:58dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0117960)
inigo_lerga   
2020-02-20 10:12   
--Test Plan Mantis HQL queries--
Part of the modified hqls in this Issue can be executed
running the JUnit tests found in the TestCosting.java file.

#In this moment the modified HQLs are executed#


For some of the rest of them:
As the F&B International Group Admin role:
  - Go to the Inventory Amount Update window and create
    a new record. Leave every field as default.
  - Go to the Lines Tab and create a new Line with
    "Cerveza Ale 0,5L" as Product.
  
  #In this moment the modified HQLs are executed#
(0118122)
hgbot   
2020-02-26 16:58   
Repository: erp/devel/pi
Changeset: a0f6363a98c186c45aba6c28b067ca8ec64b6d0e
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Feb 20 09:57:30 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a0f6363a98c186c45aba6c28b067ca8ec64b6d0e [^]

fixes BUG-43008:Applied new HQL Style + finals added

---
M src/org/openbravo/costing/CostAdjustmentUtils.java
---
(0118123)
hgbot   
2020-02-26 16:58   
Repository: erp/devel/pi
Changeset: 8c422acf29b31a03d2f2e880c456b7d40954a036
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Feb 26 16:57:51 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8c422acf29b31a03d2f2e880c456b7d40954a036 [^]

Related to ISSUE-43008. Code Review changes:
* Added final modifiers
* Split case when statements in different lines to make them more redable
* Use id's insetead of objects in hql queries
* Add missing comments

---
M src/org/openbravo/costing/CostAdjustmentUtils.java
---
(0118124)
dmiguelez   
2020-02-26 16:58   
Code Review + Testing Ok