Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042994Openbravo ERP04. Warehouse managementpublic2020-01-24 10:482020-01-30 11:09
Reporterngarcia 
Assigned ToAtulOpenbravo 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelPackaging and release
Regression date2019-12-05
Regression introduced in releasemain
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/4f441ebb434f0b6fe5f1cb81583246b4f5223814 [^]
Triggers an Emergency PackNo
Summary0042994: Validating a new costing rule is trying to create physical inventories in organizations where transactions are not allowed
DescriptionValidating a new costing rule is trying to create physical inventories in organizations where transactions are not allowed
Steps To ReproduceOn F&B client.

1. Create a new organization (name: Org A) child of F&B España, S.A of type Organization.
2. Create a new organization (name: Generic) child of "Org A" of type Generic.
3. Create a new warehouse (name: Test WH) on "Org A" organization
3. Create a new Product (name: Test) of type item and stocked.
4. Create a physical inventory to initialize the stock of the product "Test" on the warehouse "Test WH" set a cost of 10 EUR before processing the inventory.
5. Ensure that the costing background process is executed and that the transaction of the physical inventory is calculated.
6. Go to Costing RUles window and create a new costing rule for F&B España, S.A
7. Try to validate it and check the following error message is shown:

The header document belongs to an organization where transactions are not allowed
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0042847 closed AtulOpenbravo Inventory Amount Update process tries to create Physical Inventories in organizations no trx allowed 
depends on backport 00430023.0PR20Q1 closed AtulOpenbravo Validating a new costing rule is trying to create physical inventories in organizations where transactions are not allowed 
caused by defect 0042398 closed collazoandy4 When validating a new costing rule, physical inventories should be created in the warehouse's organization 
related to backport 00430033.0PR19Q4.2 closed AtulOpenbravo Validating a new costing rule is trying to create physical inventories in organizations where transactions are not allowed 
related to backport 00430043.0PR19Q3.4 closed AtulOpenbravo Validating a new costing rule is trying to create physical inventories in organizations where transactions are not allowed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-24 10:48ngarciaNew Issue
2020-01-24 10:48ngarciaAssigned To => Triage Finance
2020-01-24 10:48ngarciaOBNetwork customer => No
2020-01-24 10:48ngarciaModules => Core
2020-01-24 10:48ngarciaTriggers an Emergency Pack => No
2020-01-24 10:49ngarciaRelationship addedcaused by 0042398
2020-01-24 10:50ngarciaRelationship addedrelated to 0042847
2020-01-24 13:41AtulOpenbravoStatusnew => scheduled
2020-01-24 13:41AtulOpenbravoAssigned ToTriage Finance => AtulOpenbravo
2020-01-24 16:57AtulOpenbravoRegression date => 2019-12-05
2020-01-24 16:57AtulOpenbravoRegression introduced in release => pi
2020-01-24 16:57AtulOpenbravoRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/4f441ebb434f0b6fe5f1cb81583246b4f5223814 [^]
2020-01-24 16:57AtulOpenbravoRegression level => Production - QA Approved
2020-01-27 03:47AtulOpenbravoNote Added: 0117242
2020-01-28 09:30AtulOpenbravoRegression levelProduction - QA Approved => Packaging and release
2020-01-28 09:30AtulOpenbravoRegression introduced in releasepi => main
2020-01-28 09:32AtulOpenbravoRelationship deleteddepends on 0043004
2020-01-28 09:33AtulOpenbravoRelationship deleteddepends on 0043003
2020-01-30 10:19dmiguelezRelationship addedrelated to 0043003
2020-01-30 10:22dmiguelezRelationship addedrelated to 0043004
2020-01-30 11:07hgbotCheckin
2020-01-30 11:07hgbotNote Added: 0117356
2020-01-30 11:07hgbotStatusscheduled => resolved
2020-01-30 11:07hgbotResolutionopen => fixed
2020-01-30 11:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/82b3930f899dd00dff2170b0c0c61ea07bf8ca71 [^]
2020-01-30 11:08hgbotCheckin
2020-01-30 11:08hgbotNote Added: 0117357
2020-01-30 11:09dmiguelezReview Assigned To => dmiguelez
2020-01-30 11:09dmiguelezNote Added: 0117359
2020-01-30 11:09dmiguelezStatusresolved => closed
2020-01-30 11:09dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0117242)
AtulOpenbravo   
2020-01-27 03:47   
Test Plan

- Login as F&B International Group Admin role.
- Using Initial Organization Setup, create a new organization (name: Org A) child of F&B España, S.A of type Organization, set Include Accounting File or Accounting Reference Data = No.
- Navigate to Organization window, set above Organization summary flag = Yes and set it as ready.
- Similarly create a new organization (name: Generic) child of "Org A" of type Generic, set this organization as ready.
- Log out and Log in.
- Create a new warehouse (name: Test WH) on "Org A" organization
- Create a new Product (name: Test) of type item and stocked.
- Create a physical inventory to initialize the stock of the product "Test" on the warehouse "Test WH" set a cost of 10 EUR before processing the inventory.
- Ensure that the costing background process is executed and that the transaction of the physical inventory is calculated.
- Go to Costing Rules window and create a new costing rule for F&B España, S.A
- Try to validate it and realize that process is successful.
(0117356)
hgbot   
2020-01-30 11:07   
Repository: erp/devel/pi
Changeset: 82b3930f899dd00dff2170b0c0c61ea07bf8ca71
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Jan 27 08:11:56 2020 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/82b3930f899dd00dff2170b0c0c61ea07bf8ca71 [^]

Fixes BUG-42994:Validating a new costing rule is trying to
create physical inventories in organizations where transactions
are not allowed


** Moved method from InventoryAmountUpdateProcess to CostingUtils
to achieve reusability that uses Organization from the Parent
list of Warehouse Organization whose organization type has
transaction allowed flag set as Yes, if no such organization
is found, then use Organization from the Inventory Line when
validating costing rule process which creates Closing and
Opening Inventories.

---
M src/org/openbravo/costing/CostingRuleProcess.java
M src/org/openbravo/costing/CostingUtils.java
M src/org/openbravo/costing/InventoryAmountUpdateProcess.java
---
(0117357)
hgbot   
2020-01-30 11:08   
Repository: erp/devel/pi
Changeset: 3788eb72814b91adac057775fe6359c2d56d4b2a
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jan 30 09:58:01 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3788eb72814b91adac057775fe6359c2d56d4b2a [^]

Related to BUG-42994: Code Review changes. Added documentation to public method

---
M src/org/openbravo/costing/CostingUtils.java
---
(0117359)
dmiguelez   
2020-01-30 11:09   
Code Review + Testing Ok