Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0042943Openbravo ERPA. Platformpublic2020-01-20 09:262020-02-07 08:56
inigo_lerga 
inigo_lerga 
normalminorhave not tried
closedfixed 
5
 
3.0PR20Q2 
dmiguelez
Core
No
0042943: Apply new HQL Style in AverageCostAdjustment.java
AverageCostAdjustment.java has five HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
-
Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
No tags attached.
related to design defect 0041287 acknowledged platform Tracking issue: Convert HQL to apply new style 
Issue History
2020-01-20 09:26inigo_lergaNew Issue
2020-01-20 09:26inigo_lergaAssigned To => inigo_lerga
2020-01-20 09:26inigo_lergaModules => Core
2020-01-20 09:26inigo_lergaTriggers an Emergency Pack => No
2020-01-20 09:26inigo_lergaRelationship addedrelated to 0041287
2020-01-20 09:26inigo_lergaStatusnew => scheduled
2020-01-20 16:08inigo_lergaDescription Updatedbug_revision_view_page.php?rev_id=20173#r20173
2020-01-29 12:26inigo_lergaNote Added: 0117319
2020-02-07 08:55hgbotCheckin
2020-02-07 08:55hgbotNote Added: 0117531
2020-02-07 08:55hgbotStatusscheduled => resolved
2020-02-07 08:55hgbotResolutionopen => fixed
2020-02-07 08:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d869818445d69f4f401a61ac4f37dc94412e3f1e [^]
2020-02-07 08:55hgbotCheckin
2020-02-07 08:55hgbotNote Added: 0117532
2020-02-07 08:56dmiguelezReview Assigned To => dmiguelez
2020-02-07 08:56dmiguelezNote Added: 0117533
2020-02-07 08:56dmiguelezStatusresolved => closed
2020-02-07 08:56dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0117319)
inigo_lerga   
2020-01-29 12:26   
Test Plan Mantis HQL queries:
Execute the TestCosting.java JUnit tests.
#In this moment all the modified HQLs are executed#
(0117531)
hgbot   
2020-02-07 08:55   
Repository: erp/devel/pi
Changeset: d869818445d69f4f401a61ac4f37dc94412e3f1e
Author: IƱigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Jan 29 12:20:36 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d869818445d69f4f401a61ac4f37dc94412e3f1e [^]

fixes BUG-42943:Applied new HQL Style + finals added

---
M src/org/openbravo/costing/AverageCostAdjustment.java
---
(0117532)
hgbot   
2020-02-07 08:55   
Repository: erp/devel/pi
Changeset: 08293705eba0057a3609c62e7dced6df387fdcae
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Feb 07 08:54:31 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/08293705eba0057a3609c62e7dced6df387fdcae [^]

Related to ISSUE-42943. Code review changes:
  * Added back removed comments
  * Added back removed code
  * Added final modifiers

---
M src/org/openbravo/costing/AverageCostAdjustment.java
---
(0117533)
dmiguelez   
2020-02-07 08:56   
Code Review + Testing Ok