Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042932Retail ModulesCash uppublic2020-01-17 13:032020-01-31 13:24
Reporterinaki_garcia 
Assigned Toprakashmurugesan88 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in VersionRR20Q2 
Merge Request Status
Review Assigned TojavierRodriguez
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042932: [20Q1] [NewSkin] [UX] "Counted" and "Remaining" / "Surplus" labels show inconsistent padding in the Count Cash steps
DescriptionWhen starting the Cashup process, it is quite obvious that the "Counted" and "Remaining" labels present quite a different padding to the numbers placed to their right.
By adding counted cash amounts to make these numbers or values change, some other behaviours can be observed that include the following:

- The "Counted" label maintains constant padding over the first digit of its number
- The "Remaining" / "Surplus" label remains in the exact same position regardless of the size of the number with 7 digits or less
- The two labels are only aligned when the digit count is exactly 6 (value in thousands, which are 4 + decimal digits, which are 2)

Check the attached screenshots to observe the behaviour of the labels on different scenarios.
Steps To Reproduce0. Log in the POS as user "vallblanca"
1. Click or tap on the "Cash up" option from the dropdown menu
2. Get to the "Count cash" step
3. Make variations in the quantity of the different denominations to cause variations in the "Counted" and "Remaining" / "Surplus" values
NOTICE that the behaviours listed in the description are reproduced
Proposed SolutionA possible solution would include following these criterias:

1. The "Counted" and "Remaining"/"Surplus" values should have the same padding or be aligned one with the other
2. The padding will depend on the spacing over the largest of the two numbers
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0043015RR20Q1 closed prakashmurugesan88 [20Q1] [NewSkin] [UX] "Counted" and "Remaining" / "Surplus" labels show inconsistent padding in the Count Cash steps 
Attached Filesjpg incorrect-count-cash-label-padding-1.jpg (272,366) 2020-01-17 13:05
https://issues.openbravo.com/file_download.php?file_id=13864&type=bug
jpg incorrect-count-cash-label-padding-2.jpg (269,783) 2020-01-17 13:05
https://issues.openbravo.com/file_download.php?file_id=13865&type=bug
jpg incorrect-count-cash-label-padding-3.jpg (275,248) 2020-01-17 13:05
https://issues.openbravo.com/file_download.php?file_id=13866&type=bug
jpg incorrect-count-cash-label-padding-4.jpg (270,119) 2020-01-17 13:06
https://issues.openbravo.com/file_download.php?file_id=13867&type=bug
jpg incorrect-count-cash-label-padding-5.jpg (277,936) 2020-01-17 13:06
https://issues.openbravo.com/file_download.php?file_id=13868&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-01-17 13:03inaki_garciaNew Issue
2020-01-17 13:03inaki_garciaAssigned To => Retail
2020-01-17 13:03inaki_garciaOBNetwork customer => No
2020-01-17 13:03inaki_garciaTriggers an Emergency Pack => No
2020-01-17 13:05inaki_garciaFile Added: incorrect-count-cash-label-padding-1.jpg
2020-01-17 13:05inaki_garciaFile Added: incorrect-count-cash-label-padding-2.jpg
2020-01-17 13:05inaki_garciaFile Added: incorrect-count-cash-label-padding-3.jpg
2020-01-17 13:06inaki_garciaFile Added: incorrect-count-cash-label-padding-4.jpg
2020-01-17 13:06inaki_garciaFile Added: incorrect-count-cash-label-padding-5.jpg
2020-01-27 15:03prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2020-01-27 15:03prakashmurugesan88Statusnew => scheduled
2020-01-29 06:47hgbotCheckin
2020-01-29 06:47hgbotNote Added: 0117311
2020-01-29 06:47hgbotStatusscheduled => resolved
2020-01-29 06:47hgbotResolutionopen => fixed
2020-01-29 06:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/12e8e8e3f50fb90420ea991c3cd711ccc1f22a14 [^]
2020-01-31 13:24javierRodriguezReview Assigned To => javierRodriguez
2020-01-31 13:24javierRodriguezNote Added: 0117403
2020-01-31 13:24javierRodriguezStatusresolved => closed
2020-01-31 13:24javierRodriguezFixed in Version => RR20Q2

Notes
(0117311)
hgbot   
2020-01-29 06:47   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 12e8e8e3f50fb90420ea991c3cd711ccc1f22a14
Author: Prakash M <prakash <at> qualiantech.com>
Date: Wed Jan 29 11:16:01 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/12e8e8e3f50fb90420ea991c3cd711ccc1f22a14 [^]

Fixed issue 42932: Fixed Counted, Remaining and Surplus labels alignment in count cash

---
M web/org.openbravo.retail.posterminal/css/obpos-main.css
M web/org.openbravo.retail.posterminal/js/closecash/view/tabcashpayments.js
M web/org.openbravo.retail.posterminal/js/closecash/view/tabcountcash.js
---
(0117403)
javierRodriguez   
2020-01-31 13:24   
Reviewed