Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042929Openbravo ERP01. General setuppublic2020-01-17 12:372020-01-30 11:47
Reporterngarcia 
Assigned ToAtulOpenbravo 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042929: Wrong warning shown when trying to change the standard precision of a currency to a value higher than 2
DescriptionWrong warning shown when trying to change the standard precision of a currency to a value higher than 2 for currencies that allow it
Steps To ReproduceCheck in the ISO_4217.xml file that the Units defined for OMR are 3

In the backoffice, as System Admin role:
   Go to currency window and try to change the standard precision of OMR to a value different from 2
   Check the following warning is shown:
      The current standard precision: 3 is higher than currency precision defined on ISO 4217 specification: 2 for: OMR currency
   The log shows:
      ERROR org.openbravo.erpCommon.utility.ISOCurrencyPrecision - No ISO0417 XML file found.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0036693 closed markmm82 Openbravo ERP In Currency window, Standard precision can be higher than the currency's real precision (commonly 2) 
related to design defect 0036694 closed jorge-garcia Retail Modules In Currency window, POS precision can be higher than the currency's real precision (commonly 2) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-17 12:37ngarciaNew Issue
2020-01-17 12:37ngarciaAssigned To => Triage Finance
2020-01-17 12:37ngarciaModules => Core
2020-01-17 12:37ngarciaResolution time => 1581030000
2020-01-17 12:37ngarciaTriggers an Emergency Pack => No
2020-01-17 12:54ngarciaRelationship addedrelated to 0036693
2020-01-17 12:54ngarciaRelationship addedrelated to 0036694
2020-01-17 13:01ngarciaIssue Monitored: networkb
2020-01-20 09:36dmiguelezAssigned ToTriage Finance => AtulOpenbravo
2020-01-20 10:49AtulOpenbravoStatusnew => scheduled
2020-01-24 08:24AtulOpenbravoNote Added: 0117214
2020-01-30 11:46hgbotCheckin
2020-01-30 11:46hgbotNote Added: 0117362
2020-01-30 11:46hgbotStatusscheduled => resolved
2020-01-30 11:46hgbotResolutionopen => fixed
2020-01-30 11:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/02985617b29965c5b1d05671893d1ccb0ac784d2 [^]
2020-01-30 11:46hgbotCheckin
2020-01-30 11:46hgbotNote Added: 0117363
2020-01-30 11:47dmiguelezReview Assigned To => dmiguelez
2020-01-30 11:47dmiguelezNote Added: 0117364
2020-01-30 11:47dmiguelezStatusresolved => closed
2020-01-30 11:47dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0117214)
AtulOpenbravo   
2020-01-24 08:24   
Test Plan

-Login as System Admin
- Go to currency window and try to change the standard precision of OMR to a value different from 2
- Check the following warning is shown:
  The current standard precision: 3 is higher than currency precision defined on ISO 4217 specification: 2 for: OMR currency
- Check log messages and realize that there is no error shown.
(0117362)
hgbot   
2020-01-30 11:46   
Repository: erp/devel/pi
Changeset: 02985617b29965c5b1d05671893d1ccb0ac784d2
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri Jan 24 12:49:46 2020 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/02985617b29965c5b1d05671893d1ccb0ac784d2 [^]

Fixes BUG-0042929: Wrong warning shown when trying to change the
standard precision of a currency to a value higher than 2

**Get path of resource file ISO_4217.xml using ServletContext
along with relative path to the default design sub-folder within
the context's base design

---
M src/org/openbravo/erpCommon/utility/ISOCurrencyPrecision.java
---
(0117363)
hgbot   
2020-01-30 11:46   
Repository: erp/devel/pi
Changeset: 58082f777543893f3f839602d680c75f9b2c6370
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri Jan 24 12:52:07 2020 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/58082f777543893f3f839602d680c75f9b2c6370 [^]

Related to ISSUE-42929: Apply sonarlint suggestions

**apply sonarlint suggestions related to formatting
debug log messages.

---
M src/org/openbravo/erpCommon/utility/ISOCurrencyPrecision.java
---
(0117364)
dmiguelez   
2020-01-30 11:47   
Code Review + Testing Ok