Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042925Openbravo ERPA. Platformpublic2020-01-17 10:212020-02-06 17:17
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042925: Apply new HQL Style in AverageAlgorithm.java
DescriptionAverageAlgorithm.java has three HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-17 10:21inigo_lergaNew Issue
2020-01-17 10:21inigo_lergaAssigned To => inigo_lerga
2020-01-17 10:21inigo_lergaModules => Core
2020-01-17 10:21inigo_lergaTriggers an Emergency Pack => No
2020-01-17 10:21inigo_lergaStatusnew => scheduled
2020-01-17 10:22inigo_lergaRelationship addedrelated to 0041287
2020-01-17 14:41inigo_lergaNote Added: 0117033
2020-02-06 17:17hgbotCheckin
2020-02-06 17:17hgbotNote Added: 0117527
2020-02-06 17:17hgbotStatusscheduled => resolved
2020-02-06 17:17hgbotResolutionopen => fixed
2020-02-06 17:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e9e7c068f287a4a5d1808e41c950b9be7cf0d9f9 [^]
2020-02-06 17:17dmiguelezReview Assigned To => dmiguelez
2020-02-06 17:17dmiguelezNote Added: 0117528
2020-02-06 17:17dmiguelezStatusresolved => closed
2020-02-06 17:17dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0117033)
inigo_lerga   
2020-01-17 14:41   
Test Plan Mantis HQL queries:
As the F&B International Group Admin role:
    - Go to the Process Request window and
      create a new record with * as Organization.
      Put Costing Background Process in the Process
      field ans save the record.
    - Go to the Product window and create a new record.
      Put any SearchKey and Name, and select Alcoholic as
      Product Category.
      Create a new Line in the Price Tab and choose the
      "Tarifa Bebidas Alegres" as Price List Version and
      any Unit and List Prices desired. Save the record.
    - Go to the Goods Receipt window and create a new record with
      "Bebidas Alegres, S.L." as Business Partner.
      Create a new Line in the Lines Tab with the previously created
      Product and any Movement Quantity desired. Save the record.
    - Go back to the Process Request window and press the
      Schedule Process button of the previously created Process Request.
    #In this moment the modified HQLs are executed#
(0117527)
hgbot   
2020-02-06 17:17   
Repository: erp/devel/pi
Changeset: e9e7c068f287a4a5d1808e41c950b9be7cf0d9f9
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri Jan 17 14:29:23 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e9e7c068f287a4a5d1808e41c950b9be7cf0d9f9 [^]

fixes BUG-42925:Applied new HQL Style

---
M src/org/openbravo/costing/AverageAlgorithm.java
---
(0117528)
dmiguelez   
2020-02-06 17:17   
Code Review + Testing Ok