Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042922Openbravo ERPB. User interfacepublic2020-01-17 09:182020-02-06 17:04
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042922: Apply new HQL Style in AgingOrganizationFilterExpression.java
DescriptionAgingOrganizationFilterExpression.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-17 09:18inigo_lergaNew Issue
2020-01-17 09:18inigo_lergaAssigned To => inigo_lerga
2020-01-17 09:18inigo_lergaModules => Core
2020-01-17 09:18inigo_lergaTriggers an Emergency Pack => No
2020-01-17 09:18inigo_lergaDescription Updatedbug_revision_view_page.php?rev_id=20159#r20159
2020-01-17 09:18inigo_lergaRelationship addedrelated to 0041287
2020-01-17 09:18inigo_lergaStatusnew => scheduled
2020-01-17 10:16inigo_lergaNote Added: 0116987
2020-02-06 17:03hgbotCheckin
2020-02-06 17:03hgbotNote Added: 0117523
2020-02-06 17:03hgbotStatusscheduled => resolved
2020-02-06 17:03hgbotResolutionopen => fixed
2020-02-06 17:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/04edbbb7db075b3d644f0c1f800b510fd4be3ab6 [^]
2020-02-06 17:03hgbotCheckin
2020-02-06 17:03hgbotNote Added: 0117524
2020-02-06 17:04dmiguelezReview Assigned To => dmiguelez
2020-02-06 17:04dmiguelezNote Added: 0117525
2020-02-06 17:04dmiguelezStatusresolved => closed
2020-02-06 17:04dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0116987)
inigo_lerga   
2020-01-17 10:16   
Test Plan Mantis HQL query:
As the F&B International Group Admin role:
    - Open the Payables Aging Schedule window.
    #In this moment the modified HQL is executed#
(0117523)
hgbot   
2020-02-06 17:03   
Repository: erp/devel/pi
Changeset: 04edbbb7db075b3d644f0c1f800b510fd4be3ab6
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri Jan 17 10:11:43 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/04edbbb7db075b3d644f0c1f800b510fd4be3ab6 [^]

fixes BUG-42922:Applied new HQL Style

---
M src/org/openbravo/common/filterexpression/AgingOrganizationFilterExpression.java
---
(0117524)
hgbot   
2020-02-06 17:03   
Repository: erp/devel/pi
Changeset: 9728e9bb4a716aac28158b1bcffb4af6cd8964f8
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri Jan 17 14:50:24 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9728e9bb4a716aac28158b1bcffb4af6cd8964f8 [^]

related to ISSUE-42922: Copyright date updated

---
M src/org/openbravo/common/filterexpression/AgingOrganizationFilterExpression.java
---
(0117525)
dmiguelez   
2020-02-06 17:04   
Code Review + Testing Ok