Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042905Retail ModulesWeb POSpublic2020-01-16 12:232020-03-11 13:20
Reporterplujan 
Assigned Toprakashmurugesan88 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in VersionRR20Q2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042905: [20Q1] [NewSkin] Popup "Create Sales Order from Quotation" missing proper styling
DescriptionThe pop up shown when creating a receipt from a Quotation does not have the same style as the rest of the application
Steps To ReproduceOpen a Quotation and then check the menu option "Create sales order". See attached screenshot
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0043005RR20Q1 closed prakashmurugesan88 [20Q1] [NewSkin] Popup "Create Sales Order from Quotation" missing proper styling 
depends on backport 0043463RR20Q1 closed prakashmurugesan88 [20Q1] [NewSkin] Popup "Create Sales Order from Quotation" missing proper styling 
related to defect 0042801 closed ranjith_qualiantech_com [RR20Q1] [New Skin] [UX] Firm quotation tick button does not represent properly if its status is true or false 
Attached Filespng CreateQuotation.png (250,911) 2020-01-16 12:23
https://issues.openbravo.com/file_download.php?file_id=13849&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2020-01-16 12:23plujanNew Issue
2020-01-16 12:23plujanAssigned To => Retail
2020-01-16 12:23plujanFile Added: CreateQuotation.png
2020-01-16 12:23plujanOBNetwork customer => No
2020-01-16 12:23plujanTriggers an Emergency Pack => No
2020-01-24 10:35prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2020-01-24 14:08prakashmurugesan88Statusnew => scheduled
2020-01-28 06:35hgbotCheckin
2020-01-28 06:35hgbotNote Added: 0117274
2020-01-28 06:35hgbotStatusscheduled => resolved
2020-01-28 06:35hgbotResolutionopen => fixed
2020-01-28 06:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ae56fcefea49b07bc03c3278e6860bd8051b9e61 [^]
2020-01-28 06:36hgbotCheckin
2020-01-28 06:36hgbotNote Added: 0117275
2020-01-31 13:55javierRodriguezNote Added: 0117405
2020-01-31 13:55javierRodriguezStatusresolved => new
2020-01-31 13:55javierRodriguezResolutionfixed => open
2020-02-04 06:32hgbotCheckin
2020-02-04 06:32hgbotNote Added: 0117440
2020-02-04 06:32hgbotStatusnew => resolved
2020-02-04 06:32hgbotResolutionopen => fixed
2020-02-04 06:32hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ae56fcefea49b07bc03c3278e6860bd8051b9e61 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/323dd32740205efe344ba5fa78fb9fb8d772a978 [^]
2020-02-10 09:29guilleaerReview Assigned To => guilleaer
2020-02-10 09:29guilleaerStatusresolved => closed
2020-02-10 09:29guilleaerFixed in Version => RR20Q2
2020-02-11 09:56ranjith_qualiantech_comRelationship addedrelated to 0042801
2020-02-26 13:20plujanAssigned Toprakashmurugesan88 => guilleaer
2020-02-26 13:20plujanNote Added: 0118119
2020-02-26 13:20plujanStatusclosed => new
2020-02-26 13:20plujanResolutionfixed => open
2020-02-26 13:20plujanFixed in VersionRR20Q2 =>
2020-03-02 13:14guilleaerTarget Version => RR20Q1
2020-03-10 10:42prakashmurugesan88Assigned Toguilleaer => prakashmurugesan88
2020-03-10 10:43prakashmurugesan88Statusnew => scheduled
2020-03-10 10:43prakashmurugesan88Target VersionRR20Q1 =>
2020-03-10 11:03hgbotCheckin
2020-03-10 11:03hgbotNote Added: 0118457
2020-03-10 11:03hgbotStatusscheduled => resolved
2020-03-10 11:03hgbotResolutionopen => fixed
2020-03-10 11:03hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/323dd32740205efe344ba5fa78fb9fb8d772a978 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/09e9c1e714b992266267e4026b1e7065ebb24bc7 [^]
2020-03-11 13:20guilleaerStatusresolved => closed
2020-03-11 13:20guilleaerFixed in Version => RR20Q2

Notes
(0117274)
hgbot   
2020-01-28 06:35   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ae56fcefea49b07bc03c3278e6860bd8051b9e61
Author: Prakash M <prakash <at> qualiantech.com>
Date: Fri Jan 24 18:29:32 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ae56fcefea49b07bc03c3278e6860bd8051b9e61 [^]

Fixed issue 42905 : Applied new styling in Create Sales Order from Quotation

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/css/obpos-main.css
M web/org.openbravo.retail.posterminal/js/components/modalcreateorderfromquotation.js
---
(0117275)
hgbot   
2020-01-28 06:36   
Repository: tools/automation/pi-mobile
Changeset: 1733673539f8b5efc1a5d8e4d2d8ec0c414eab12
Author: Prakash M <prakash <at> qualiantech.com>
Date: Tue Jan 28 11:04:36 2020 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1733673539f8b5efc1a5d8e4d2d8ec0c414eab12 [^]

Related to issue 42905 : Changed tests id as per new styling in Create Sales Order

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
---
(0117405)
javierRodriguez   
2020-01-31 13:55   
New styling has been added correctly. However, There are some parts which could be implemented better.

The main problem is inside checked reference in 'OB.OBPOSPointOfSale.UI.Modals.btnModalCreateOrderAccept'. First of all, you should define initComponents function, which create a popup reference. ex:

  this.popup = OB.UTIL.getPopupFromComponent(this);

After that, you can improve check reference. ex:

  this.popup.$.footer.$.formElementCheckUpdatePrice.coreElement.checked
(0117440)
hgbot   
2020-02-04 06:32   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 323dd32740205efe344ba5fa78fb9fb8d772a978
Author: Prakash M <prakash <at> qualiantech.com>
Date: Tue Feb 04 11:01:36 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/323dd32740205efe344ba5fa78fb9fb8d772a978 [^]

Fixed issue 42905 : Improved check reference in components

---
M web/org.openbravo.retail.posterminal/js/components/modalcreateorderfromquotation.js
---
(0118119)
plujan   
2020-02-26 13:20   
In order to fully comply with the new styling, the Create Sales Order button should be at the right and marked as the default action (green background) while Cancel button should be at the left of the default one.
(0118457)
hgbot   
2020-03-10 11:03   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 09e9c1e714b992266267e4026b1e7065ebb24bc7
Author: Prakash M <prakash <at> qualiantech.com>
Date: Tue Mar 10 15:31:26 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/09e9c1e714b992266267e4026b1e7065ebb24bc7 [^]

Fixed BUG-42905: Create Sales Order button placed right and marked default action

---
M web/org.openbravo.retail.posterminal/js/components/modalcreateorderfromquotation.js
---