Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042882Openbravo ERPA. Platformpublic2020-01-15 10:282020-02-06 16:50
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042882: Apply new HQL Style in CostingTransactionsHQLTransformer.java
DescriptionCostingTransactionsHQLTransformer.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-15 10:28inigo_lergaNew Issue
2020-01-15 10:28inigo_lergaAssigned To => inigo_lerga
2020-01-15 10:28inigo_lergaModules => Core
2020-01-15 10:28inigo_lergaTriggers an Emergency Pack => No
2020-01-15 10:28inigo_lergaRelationship addedrelated to 0041287
2020-01-15 13:45inigo_lergaStatusnew => scheduled
2020-01-15 13:47inigo_lergaDescription Updatedbug_revision_view_page.php?rev_id=20127#r20127
2020-01-16 17:08inigo_lergaNote Added: 0116942
2020-02-06 16:49hgbotCheckin
2020-02-06 16:49hgbotNote Added: 0117520
2020-02-06 16:49hgbotStatusscheduled => resolved
2020-02-06 16:49hgbotResolutionopen => fixed
2020-02-06 16:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7bc9944620b3800bdeeb94a5c439e14f30cd8a7a [^]
2020-02-06 16:49hgbotCheckin
2020-02-06 16:49hgbotNote Added: 0117521
2020-02-06 16:49hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/7bc9944620b3800bdeeb94a5c439e14f30cd8a7a [^] => http://code.openbravo.com/erp/devel/pi/rev/1d8684e8e184db487c68b6fa065d726c7c41e504 [^]
2020-02-06 16:50dmiguelezReview Assigned To => dmiguelez
2020-02-06 16:50dmiguelezNote Added: 0117522
2020-02-06 16:50dmiguelezStatusresolved => closed
2020-02-06 16:50dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0116942)
inigo_lerga   
2020-01-16 17:08   
Test Plan Mantis HQL queries:
As the F&B International Group Admin role:
    - Go to the Product window and open the record
      of "Cerveza Lager 0,5L".
    - Go to the Tab Costing.
    - Select any record with an Inventory Transaction.
    - Go to the Average Cost Transactions.
    #In this moment the modified HQL is executed#
(0117520)
hgbot   
2020-02-06 16:49   
Repository: erp/devel/pi
Changeset: 7bc9944620b3800bdeeb94a5c439e14f30cd8a7a
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Jan 16 17:03:35 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7bc9944620b3800bdeeb94a5c439e14f30cd8a7a [^]

fixes BUG-42882:Applied new HQL Style

---
M src/org/openbravo/common/datasource/CostingTransactionsHQLTransformer.java
---
(0117521)
hgbot   
2020-02-06 16:49   
Repository: erp/devel/pi
Changeset: 1d8684e8e184db487c68b6fa065d726c7c41e504
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri Jan 17 09:24:29 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1d8684e8e184db487c68b6fa065d726c7c41e504 [^]

fixes BUG-42882:Applied TRY result corrections

---
M src/org/openbravo/common/datasource/CostingTransactionsHQLTransformer.java
---
(0117522)
dmiguelez   
2020-02-06 16:50   
Code Review + Testing Ok