Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042878Openbravo ERPA. Platformpublic2020-01-15 09:342020-01-20 18:23
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042878: Apply new HQL Style in UpdatePricesAndAmounts.java
DescriptionUpdateInvoiceLineInformation.java has two HQL queries with:
- the HQL is hard to read because of formatting
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-15 09:34inigo_lergaNew Issue
2020-01-15 09:34inigo_lergaAssigned To => inigo_lerga
2020-01-15 09:34inigo_lergaOBNetwork customer => No
2020-01-15 09:34inigo_lergaModules => Core
2020-01-15 09:34inigo_lergaTriggers an Emergency Pack => No
2020-01-15 09:34inigo_lergaRelationship addedrelated to 0041287
2020-01-15 11:42inigo_lergaStatusnew => scheduled
2020-01-15 13:22inigo_lergaNote Added: 0116897
2020-01-20 18:23hgbotCheckin
2020-01-20 18:23hgbotNote Added: 0117098
2020-01-20 18:23hgbotStatusscheduled => resolved
2020-01-20 18:23hgbotResolutionopen => fixed
2020-01-20 18:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e21a59b122350c0728b44d9ba323920e84d8eaf7 [^]
2020-01-20 18:23hgbotCheckin
2020-01-20 18:23hgbotNote Added: 0117099
2020-01-20 18:23dmiguelezReview Assigned To => dmiguelez
2020-01-20 18:23dmiguelezNote Added: 0117100
2020-01-20 18:23dmiguelezStatusresolved => closed
2020-01-20 18:23dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0116897)
inigo_lerga   
2020-01-15 13:22   
Test Plan Mantis:
As the F&B International Group Admin role, F&B US, Inc. as Organization
and Warehouse US East Coast:
    - Go to the Goods Shipment window and create
      a new record with "Moon Light Restaurants, Co."
      as Business Partner.
    - Go to the Lines Tab and create a new record with
      "Lager Beer" product and 10 units in Movement Quantity
      field.
    - Save the record and press the Complete button. In the
      popup window press the OK button taking into account
      that the Invoice if possible checkbox is not checked.
    - Go to the Sales Invoice window and create a new record
      with "Moon Light Restaurants, Co." as Business Partner.
      Click the Create Lines From Shipment button and select
      the previously created Goods Shipment. Press the Done
      button.
      
#In this moment the modified HQL is executed#
(0117098)
hgbot   
2020-01-20 18:23   
Repository: erp/devel/pi
Changeset: e21a59b122350c0728b44d9ba323920e84d8eaf7
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Jan 15 13:23:43 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e21a59b122350c0728b44d9ba323920e84d8eaf7 [^]

fixes BUG-42878:Applied new HQL Style

---
M src/org/openbravo/common/actionhandler/createlinesfromprocess/UpdatePricesAndAmounts.java
---
(0117099)
hgbot   
2020-01-20 18:23   
Repository: erp/devel/pi
Changeset: 05eb9a97dc3b54559af57832e328fbf0508fcbb2
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Jan 20 18:22:55 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/05eb9a97dc3b54559af57832e328fbf0508fcbb2 [^]

Related to ISSUE-42878: Code Review changes:
* Do not use Boolean.TRUE, keep old comparison as the code
is more redable
* Select word in query must be lowercase

---
M src/org/openbravo/common/actionhandler/createlinesfromprocess/UpdatePricesAndAmounts.java
---
(0117100)
dmiguelez   
2020-01-20 18:23   
Code Review + Testing Ok