Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042854Openbravo ERPA. Platformpublic2020-01-14 13:532020-01-20 17:42
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042854: Apply new HQL Style in CreateLinesFromUtil.java
DescriptionCreateLinesFromUtil.java has one HQL query with:
- the HQL is hard to read because of formatting
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-14 13:53inigo_lergaNew Issue
2020-01-14 13:53inigo_lergaAssigned To => inigo_lerga
2020-01-14 13:53inigo_lergaModules => Core
2020-01-14 13:53inigo_lergaTriggers an Emergency Pack => No
2020-01-14 13:55inigo_lergaRelationship addedrelated to 0041287
2020-01-15 08:28inigo_lergaStatusnew => scheduled
2020-01-15 09:25inigo_lergaNote Added: 0116881
2020-01-20 17:41dmiguelezNote Added: 0117087
2020-01-20 17:42hgbotCheckin
2020-01-20 17:42hgbotNote Added: 0117088
2020-01-20 17:42hgbotStatusscheduled => resolved
2020-01-20 17:42hgbotResolutionopen => fixed
2020-01-20 17:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/490bb3f0f54b1f2ebd7ec6f95f2e81a49af5001a [^]
2020-01-20 17:42hgbotCheckin
2020-01-20 17:42hgbotNote Added: 0117089
2020-01-20 17:42hgbotCheckin
2020-01-20 17:42hgbotNote Added: 0117090
2020-01-20 17:42dmiguelezReview Assigned To => dmiguelez
2020-01-20 17:42dmiguelezNote Added: 0117092
2020-01-20 17:42dmiguelezStatusresolved => closed
2020-01-20 17:42dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0116881)
inigo_lerga   
2020-01-15 09:25   
Test Plan Mantis:
As the F&B International Group Admin role:
    - Go to the Sales Order window and create
      a new record with "Alimentos y Supermercados, S.A"
      as Business Partner, and Invoice Terms field as
      "Immediate".
    - Go to the Lines Tab and create a new record with
      "Cerveza Ale 0,5L" product with 70 in the
      Ordered Quantity field.
    - Press the Book button and then OK button in the
      popup window.
    - Go to the Create Shipment from Orders window
      and select the previously created Sales Order.
      Click in the Process button.
    - Go to the Sales Invoice window and create a new
      record with "Alimentos y Supermercados, S.A" as
      Business Partner. Then press the Create Lines
      From Order button and select all the lines from
      the Sales Order previously created. Press the
      Done button.
      
#In this moment the modified HQL is executed#
(0117087)
dmiguelez   
2020-01-20 17:41   
Test plan II.

Follow same test plan with Purchase flow
Purchase Order - Goods Receipt - Purchase Invoice
Any Business Partner and any Product
(0117088)
hgbot   
2020-01-20 17:42   
Repository: erp/devel/pi
Changeset: 490bb3f0f54b1f2ebd7ec6f95f2e81a49af5001a
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Jan 15 09:28:05 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/490bb3f0f54b1f2ebd7ec6f95f2e81a49af5001a [^]

fixes BUG-42854:Applied new HQL Style

---
M src/org/openbravo/common/actionhandler/createlinesfromprocess/CreateLinesFromUtil.java
---
(0117089)
hgbot   
2020-01-20 17:42   
Repository: erp/devel/pi
Changeset: e470e8f2596ec880e6be132dc24cd8f81f90db4f
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Jan 15 12:12:12 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e470e8f2596ec880e6be132dc24cd8f81f90db4f [^]

related to ISSUE-42854: Copyright date updated

---
M src/org/openbravo/common/actionhandler/createlinesfromprocess/CreateLinesFromUtil.java
---
(0117090)
hgbot   
2020-01-20 17:42   
Repository: erp/devel/pi
Changeset: 60e8ef55b74402a02e388ab81d16b4b7bd87b494
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Jan 20 17:41:49 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/60e8ef55b74402a02e388ab81d16b4b7bd87b494 [^]

Related to ISSUE-42854: Code Review changes:
* Do not use Boolean.TRUE, keep old comparison as the code
is more redable

---
M src/org/openbravo/common/actionhandler/createlinesfromprocess/CreateLinesFromUtil.java
---
(0117092)
dmiguelez   
2020-01-20 17:42   
Code Review + Testing Ok