Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042848Openbravo ERPA. Platformpublic2020-01-14 12:442020-01-20 17:10
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042848: Apply new HQL Style in UpdatePricesAndAmounts.java
DescriptionUpdatePricesAndAmounts.java has one HQL query with:
- the HQL is hard to read because of formatting
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-14 12:44inigo_lergaNew Issue
2020-01-14 12:44inigo_lergaAssigned To => inigo_lerga
2020-01-14 12:44inigo_lergaModules => Core
2020-01-14 12:44inigo_lergaTriggers an Emergency Pack => No
2020-01-14 12:45inigo_lergaRelationship addedrelated to 0041287
2020-01-14 13:52inigo_lergaStatusnew => scheduled
2020-01-14 16:51inigo_lergaNote Added: 0116870
2020-01-20 17:10hgbotCheckin
2020-01-20 17:10hgbotNote Added: 0117085
2020-01-20 17:10hgbotStatusscheduled => resolved
2020-01-20 17:10hgbotResolutionopen => fixed
2020-01-20 17:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/439ff3aa27d9b95b17a923ecdb30ccc48afc28ad [^]
2020-01-20 17:10dmiguelezReview Assigned To => dmiguelez
2020-01-20 17:10dmiguelezNote Added: 0117086
2020-01-20 17:10dmiguelezStatusresolved => closed
2020-01-20 17:10dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0116870)
inigo_lerga   
2020-01-14 16:51   
Test Plan Mantis:
As the F&B International Group Admin role with F&B US, Inc
as Organization and US East Coast as Warehouse:
    - Go to the Purchase Order window and create
      a new record with "Happy Drinks, Inc." as
      business partner. Press the Copy from Orders
      and select any record with "Be Soft Drinker, Inc."
      Press the Done button.
      
#In this moment the modified HQL is executed#
(0117085)
hgbot   
2020-01-20 17:10   
Repository: erp/devel/pi
Changeset: 439ff3aa27d9b95b17a923ecdb30ccc48afc28ad
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Jan 14 16:42:21 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/439ff3aa27d9b95b17a923ecdb30ccc48afc28ad [^]

fixes BUG-42848:Applied new HQL Style

---
M src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdatePricesAndAmounts.java
---
(0117086)
dmiguelez   
2020-01-20 17:10   
Code Review + Testing Ok