Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0042845Openbravo ERPA. Platformpublic2020-01-14 12:392020-01-20 13:40
inigo_lerga 
inigo_lerga 
normalminorhave not tried
closedfixed 
5
 
3.0PR20Q2 
dmiguelez
Core
No
0042845: Apply new HQL Style in APRM_MatchingUtility.java
APRM_MatchingUtility.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
-
Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
No tags attached.
related to design defect 0041287 acknowledged platform Tracking issue: Convert HQL to apply new style 
Issue History
2020-01-14 12:39inigo_lergaNew Issue
2020-01-14 12:39inigo_lergaAssigned To => inigo_lerga
2020-01-14 12:39inigo_lergaModules => Core
2020-01-14 12:39inigo_lergaTriggers an Emergency Pack => No
2020-01-14 12:39inigo_lergaRelationship addedrelated to 0041287
2020-01-14 12:39inigo_lergaStatusnew => scheduled
2020-01-14 12:40inigo_lergaDescription Updatedbug_revision_view_page.php?rev_id=20096#r20096
2020-01-14 13:00inigo_lergaDescription Updatedbug_revision_view_page.php?rev_id=20097#r20097
2020-01-14 13:41inigo_lergaNote Added: 0116856
2020-01-20 13:39hgbotCheckin
2020-01-20 13:39hgbotNote Added: 0117071
2020-01-20 13:39hgbotStatusscheduled => resolved
2020-01-20 13:39hgbotResolutionopen => fixed
2020-01-20 13:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3e653c96fb2ca6a8a866edc03e950825deee7dcd [^]
2020-01-20 13:39hgbotCheckin
2020-01-20 13:39hgbotNote Added: 0117072
2020-01-20 13:39hgbotCheckin
2020-01-20 13:39hgbotNote Added: 0117073
2020-01-20 13:40dmiguelezReview Assigned To => dmiguelez
2020-01-20 13:40dmiguelezNote Added: 0117074
2020-01-20 13:40dmiguelezStatusresolved => closed
2020-01-20 13:40dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0116856)
inigo_lerga   
2020-01-14 13:41   
Test Plan Mantis:
As the F&B International Group Admin role:
    - Go to the Financial Account and open
      the "Cuenta de Banco" record.
    - Enter the Imported Bank Statements
      Tab and create a new record. Write
      any name desired and save. Go the
      Bank Statement Lines Tab inside this
      Imported Bank Statement and create a new record
      with the Reference No as "101010" and
      Amount In field with 500.
    - Go back to the Imported Bank Statement
      and press the Process button and OK button
      inside the popup window.
    - Go back to the Financial Account record and
      press the Match Statement button and OK in
      the popup window.
      
#In this moment the modified HQL is executed#
(0117071)
hgbot   
2020-01-20 13:39   
Repository: erp/devel/pi
Changeset: 3e653c96fb2ca6a8a866edc03e950825deee7dcd
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Jan 14 13:32:33 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3e653c96fb2ca6a8a866edc03e950825deee7dcd [^]

fixes BUG-42845:Applied new HQL Style

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/APRM_MatchingUtility.java
---
(0117072)
hgbot   
2020-01-20 13:39   
Repository: erp/devel/pi
Changeset: 4afe620f4e46f01cbf302349f4aed1f79bc78461
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Jan 14 13:50:25 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4afe620f4e46f01cbf302349f4aed1f79bc78461 [^]

related to ISSUE-42845: Applied Sonarlint suggestions

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/APRM_MatchingUtility.java
---
(0117073)
hgbot   
2020-01-20 13:39   
Repository: erp/devel/pi
Changeset: 5d98a003231a7da2359013f15cf51338712d247d
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Jan 20 13:38:15 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5d98a003231a7da2359013f15cf51338712d247d [^]

Related to ISSUE-42845: Code Review changes:
* Do not use Boolean.TRUE, keep old comparison as the code
is more redable

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/APRM_MatchingUtility.java
---
(0117074)
dmiguelez   
2020-01-20 13:40   
Code Review + Testing Ok