0042831: ant package.module is missing to exclude .git

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0042831

Openbravo ERP

A. Platform

public

2020-01-09 13:59

2020-01-14 10:16

Reporter

shuehner

Assigned To

alostale

Priority

urgent

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

3.0PR19Q4.2

Fixed in Version

3.0PR19Q4.2

Merge Request Status

Review Assigned To

caristu

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0042831: ant package.module is missing to exclude .git

Description

The standard ant package.module task used to package modules by developers is missing to exclude .git folder.

It currently has excludes for both .hg & .svn but is missing to add same for .git

Consequence is it including all git repo history (if present) inside the obx file making them unnecessarily large.

On some occasions it can cause later secondary problem with module management as it tries to overwrite some read-only files inside .git in case of updating a module via mmc (having .git inside obx) when older module version also have .git files present.

Relevant code to which the new (.git) case should be added:
https://code.openbravo.com/erp/devel/pi/file/tip/src/org/openbravo/erpCommon/modules/ExtractModule.java#l232 [^]

Steps To Reproduce

Clone any module which is hosted as a git repository and run ant package.module to create obx file.

Check obx file (unzip -v) and notice it does contain .git.

Proposed Solution

Additional Information