Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042814Openbravo ERPA. Platformpublic2020-01-13 11:322020-01-17 14:18
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042814: Apply new HQL Style in FIN_AddPayment.java
DescriptionFIN_AddPayment.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-13 11:32inigo_lergaNew Issue
2020-01-13 11:32inigo_lergaAssigned To => inigo_lerga
2020-01-13 11:32inigo_lergaModules => Core
2020-01-13 11:32inigo_lergaTriggers an Emergency Pack => No
2020-01-13 11:33inigo_lergaStatusnew => scheduled
2020-01-13 11:33inigo_lergaRelationship addedrelated to 0041287
2020-01-13 11:48inigo_lergaDescription Updatedbug_revision_view_page.php?rev_id=20087#r20087
2020-01-13 12:11inigo_lergaNote Added: 0116793
2020-01-17 14:17hgbotCheckin
2020-01-17 14:17hgbotNote Added: 0117025
2020-01-17 14:17hgbotStatusscheduled => resolved
2020-01-17 14:17hgbotResolutionopen => fixed
2020-01-17 14:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ca7c137a2054e2e68b6eb81816e47f5a4ba85e1a [^]
2020-01-17 14:17hgbotCheckin
2020-01-17 14:17hgbotNote Added: 0117026
2020-01-17 14:17hgbotCheckin
2020-01-17 14:17hgbotNote Added: 0117027
2020-01-17 14:18dmiguelezReview Assigned To => dmiguelez
2020-01-17 14:18dmiguelezNote Added: 0117028
2020-01-17 14:18dmiguelezStatusresolved => closed
2020-01-17 14:18dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0116793)
inigo_lerga   
2020-01-13 12:11   
Test Plan Mantis:
As the F&B International Group Admin role:
    - Go to the Payment Proposal window and
      select any record. Press the Reactivate
      button and press Process button in the
      popup window.

#In this moment the modified HQL is executed#
(0117025)
hgbot   
2020-01-17 14:17   
Repository: erp/devel/pi
Changeset: ca7c137a2054e2e68b6eb81816e47f5a4ba85e1a
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Jan 13 12:13:51 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ca7c137a2054e2e68b6eb81816e47f5a4ba85e1a [^]

fixes BUG-42814:Applied new HQL Style

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java
---
(0117026)
hgbot   
2020-01-17 14:17   
Repository: erp/devel/pi
Changeset: 995bdde4ffb5f63ccd1a392d3a3e31470433111b
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Jan 13 12:37:12 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/995bdde4ffb5f63ccd1a392d3a3e31470433111b [^]

related to ISSUE-42814: Applied Sonarlint suggestions

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java
---
(0117027)
hgbot   
2020-01-17 14:17   
Repository: erp/devel/pi
Changeset: d98e412837b0a4dafa37d3bd7481321eab7d3529
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jan 17 14:17:35 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d98e412837b0a4dafa37d3bd7481321eab7d3529 [^]

Related to ISSUE-42814: Code Review Changes:
* Do not use Boolean.TRUE, keep old comparison as the code
  is more redable

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java
---
(0117028)
dmiguelez   
2020-01-17 14:18   
Code Review + Testing Ok