Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042813Openbravo ERPA. Platformpublic2020-01-13 10:392020-01-17 14:07
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042813: Apply new HQL Style in FundsTransferGLItemDefaultValueExpression.java
DescriptionFundsTransferGLItemDefaultValueExpression.java has one HQL query with:
- the HQL is hard to read because of formatting
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-13 10:39inigo_lergaNew Issue
2020-01-13 10:39inigo_lergaAssigned To => inigo_lerga
2020-01-13 10:39inigo_lergaModules => Core
2020-01-13 10:39inigo_lergaTriggers an Emergency Pack => No
2020-01-13 10:39inigo_lergaStatusnew => scheduled
2020-01-13 10:39inigo_lergaRelationship addedrelated to 0041287
2020-01-13 11:26inigo_lergaNote Added: 0116792
2020-01-17 14:06hgbotCheckin
2020-01-17 14:06hgbotNote Added: 0117022
2020-01-17 14:06hgbotStatusscheduled => resolved
2020-01-17 14:06hgbotResolutionopen => fixed
2020-01-17 14:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/670f653c3739f2356b3ed7deebc19e00aa2184f9 [^]
2020-01-17 14:07dmiguelezReview Assigned To => dmiguelez
2020-01-17 14:07dmiguelezNote Added: 0117023
2020-01-17 14:07dmiguelezStatusresolved => closed
2020-01-17 14:07dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0116792)
inigo_lerga   
2020-01-13 11:26   
Test Plan Mantis:
As the F&B International Group Admin role:
    - Go to the Financial Account window and
      enter the "Cuenta de Banco" record.
      Press the Funds Tranfer button.

#In this moment the modified HQL is executed#
(0117022)
hgbot   
2020-01-17 14:06   
Repository: erp/devel/pi
Changeset: 670f653c3739f2356b3ed7deebc19e00aa2184f9
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Jan 13 11:27:40 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/670f653c3739f2356b3ed7deebc19e00aa2184f9 [^]

fixes BUG-42813:Applied new HQL Style

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/FundsTransferGLItemDefaultValueExpression.java
---
(0117023)
dmiguelez   
2020-01-17 14:07   
Code Review + Testing Ok