Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042804Openbravo ERPA. Platformpublic2020-01-10 14:232020-03-20 17:54
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042804: Apply new HQL Style in FIN_ReconciliationEventListener.java
DescriptionFIN_ReconciliationEventListener.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-10 14:23inigo_lergaNew Issue
2020-01-10 14:23inigo_lergaAssigned To => inigo_lerga
2020-01-10 14:23inigo_lergaOBNetwork customer => No
2020-01-10 14:23inigo_lergaModules => Core
2020-01-10 14:23inigo_lergaTriggers an Emergency Pack => No
2020-01-10 14:23inigo_lergaStatusnew => scheduled
2020-01-10 14:43inigo_lergaDescription Updatedbug_revision_view_page.php?rev_id=20081#r20081
2020-01-10 14:44inigo_lergaRelationship addedrelated to 0041287
2020-01-13 09:02inigo_lergaNote Added: 0116781
2020-01-13 19:11hgbotCheckin
2020-01-13 19:11hgbotNote Added: 0116812
2020-01-13 19:11hgbotCheckin
2020-01-13 19:11hgbotNote Added: 0116813
2020-01-13 19:18dmiguelezStatusscheduled => resolved
2020-01-13 19:18dmiguelezFixed in Version => 3.0PR20Q2
2020-01-13 19:18dmiguelezFixed in SCM revision => https://code.openbravo.com/erp/devel/pi/rev/4f108937f1beca703861c7bba28cf55eebdc3ea3 [^]
2020-01-13 19:18dmiguelezResolutionopen => fixed
2020-01-13 19:19dmiguelezReview Assigned To => dmiguelez
2020-01-13 19:19dmiguelezNote Added: 0116814
2020-01-13 19:19dmiguelezStatusresolved => closed
2020-03-20 17:54hudsonbotCheckin
2020-03-20 17:54hudsonbotNote Added: 0118729
2020-03-20 17:54hudsonbotCheckin
2020-03-20 17:54hudsonbotNote Added: 0118730

Notes
(0116781)
inigo_lerga   
2020-01-13 09:02   
Test Plan Mantis:
As the F&B International Group Admin role:
    - Go to the Financial Account window and
      enter in the "Cuenta de Banco" record.
      Enter the Reconciliations tab and go to
      the most recent one. Reactivate the
      reconciliation and press the Delete button.

#In this moment the modified HQL is executed#
(0116812)
hgbot   
2020-01-13 19:11   
Repository: erp/devel/pi
Changeset: 4f108937f1beca703861c7bba28cf55eebdc3ea3
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Jan 13 08:48:54 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4f108937f1beca703861c7bba28cf55eebdc3ea3 [^]

Related to Issue 42804: Applied new HQL Style

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/event/FIN_ReconciliationEventListener.java
---
(0116813)
hgbot   
2020-01-13 19:11   
Repository: erp/devel/pi
Changeset: 51251e3b315a27d303f22d4c3d5f1b05b6a0fc6d
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Jan 13 19:09:56 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/51251e3b315a27d303f22d4c3d5f1b05b6a0fc6d [^]

Related to Issue 42804: Code Review changes. Split update clause in two lines

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/event/FIN_ReconciliationEventListener.java
---
(0116814)
dmiguelez   
2020-01-13 19:19   
Code Review + Testing Ok
(0118729)
hudsonbot   
2020-03-20 17:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b31620115262 [^]
Maturity status: Test
(0118730)
hudsonbot   
2020-03-20 17:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b31620115262 [^]
Maturity status: Test