Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042789Openbravo ERP02. Master data managementpublic2020-01-10 06:512020-01-21 16:38
ReporterAtulOpenbravo 
Assigned ToAtulOpenbravo 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042789: Apply new HQL style in ServicesModifyTaxCopyConfiguration
Description1. Avoid use of StringBuilder use normal Strings.
2. HQL formatting is important for improving readability.
3. Avoid use of Property Constant if any
Steps To Reproduce-
Proposed SolutionFollow new style available here http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
depends on design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Not all the children of this issue are yet resolved or closed.
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-10 06:51AtulOpenbravoNew Issue
2020-01-10 06:51AtulOpenbravoAssigned To => AtulOpenbravo
2020-01-10 06:51AtulOpenbravoModules => Core
2020-01-10 06:51AtulOpenbravoTriggers an Emergency Pack => No
2020-01-10 06:51AtulOpenbravoIssue generated from0042788
2020-01-10 06:51AtulOpenbravoRelationship addeddepends on 0041287
2020-01-10 06:54AtulOpenbravoIssue cloned0042790
2020-01-14 11:01AtulOpenbravoStatusnew => scheduled
2020-01-14 11:01AtulOpenbravoNote Added: 0116835
2020-01-15 09:45AtulOpenbravoIssue cloned0042879
2020-01-21 16:31hgbotCheckin
2020-01-21 16:31hgbotNote Added: 0117156
2020-01-21 16:31hgbotStatusscheduled => resolved
2020-01-21 16:31hgbotResolutionopen => fixed
2020-01-21 16:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5da059cf95b807366a83a82908d3ae8255c6f718 [^]
2020-01-21 16:31hgbotCheckin
2020-01-21 16:31hgbotNote Added: 0117157
2020-01-21 16:38dmiguelezReview Assigned To => dmiguelez
2020-01-21 16:38dmiguelezNote Added: 0117158
2020-01-21 16:38dmiguelezStatusresolved => closed
2020-01-21 16:38dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0116835)
AtulOpenbravo   
2020-01-14 11:01   
Test Plan
- Define Service product, Type as:Service set Linked To Product = Yes, Include Product Categories: blank, Include Products : Only those Defined, Quantity Rule: As per Product
- Set Modify Tax flag = Yes
- Run Modify Tax for Product Category process, select any category and set Tax for it.
- Realize that record appears in Modify Tax Categories Tab
- Create one more Service Product, set Linked To Product = Yes, Include Product Categories: blank, Include Products : Only those Defined, Quantity Rule: As per Product, Set Modify flag = Yes.
- Click on Copy Service Modify Tax Configuration, select the first created product shown in P&E window, Press Done
- Realize that records are created in Modify Tax Categories Tab.
(0117156)
hgbot   
2020-01-21 16:31   
Repository: erp/devel/pi
Changeset: 5da059cf95b807366a83a82908d3ae8255c6f718
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Jan 14 15:33:49 2020 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/5da059cf95b807366a83a82908d3ae8255c6f718 [^]

Fixes BUG-42789:Apply new HQL style in
ServicesModifyTaxCopyConfiguration

**Avoid StringBuilder for hql query string, use String
to format hql to improve readability of query strings
using formatter off on as required.

---
M src/org/openbravo/common/actionhandler/ServicesModifyTaxCopyConfiguration.java
---
(0117157)
hgbot   
2020-01-21 16:31   
Repository: erp/devel/pi
Changeset: b91a5a580301f609c9ffc7940a5650756818b9e5
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Jan 21 12:09:57 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b91a5a580301f609c9ffc7940a5650756818b9e5 [^]

Related to ISSUE-42789. Code Review changes:
* Changed named of variable to reflect better it's behavior
* Send variables in proper order in method
* Simplify the call to the query object

---
M src/org/openbravo/common/actionhandler/ServicesModifyTaxCopyConfiguration.java
---
(0117158)
dmiguelez   
2020-01-21 16:38   
Code Review + Testing Ok