Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042775Openbravo ERPA. Platformpublic2020-01-09 15:592020-04-16 07:54
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR20Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042775: ant package.core is tied to mercurial and cannot be used with ob source in git
DescriptionThe ant package.core command can be used to create a obx file for core. However it is doing 'hg archive' as main command to prepare the files so cannot be used when sources are managed using git.

Note:
Before changing code probably would need to specify what exactly the goal of the task is as currently it is not used and works differently than package.module.

Steps To ReproduceClone openbravo erp sources from git and run ant package.core
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0042769 closed alostale ant package.module is missing to exclude .git 
blocks feature request 0041898 acknowledged Triage Platform Base support git 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-09 15:59shuehnerNew Issue
2020-01-09 15:59shuehnerAssigned To => platform
2020-01-09 15:59shuehnerModules => Core
2020-01-09 15:59shuehnerTriggers an Emergency Pack => No
2020-01-09 16:00shuehnerRelationship addedrelated to 0042769
2020-01-09 16:01shuehnerNote Added: 0116732
2020-01-14 09:11alostaleRelationship addedblocks 0041898
2020-04-13 17:56shuehnerNote Added: 0119139
2020-04-13 17:58shuehnerAssigned Toplatform => shuehner
2020-04-14 18:34hgbotCheckin
2020-04-14 18:34hgbotNote Added: 0119160
2020-04-14 18:34hgbotStatusnew => resolved
2020-04-14 18:34hgbotResolutionopen => fixed
2020-04-14 18:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c130f7d85747d2ff9cd2038c4138ea15b9e8b289 [^]
2020-04-16 07:54alostaleReview Assigned To => alostale
2020-04-16 07:54alostaleStatusresolved => closed
2020-04-16 07:54alostaleFixed in Version => 3.0PR20Q3

Notes
(0116732)
shuehner   
2020-01-09 16:01   
Notes:
- ant package.module has some code (in ExtractModule) specific to module_id=0 but not fully working
- ant package.core does use 'hg archive' and not files from working copy (in contrast to ant package.module)
- ant package.core does have 2 options on how to set ad_module.xml version field
  a.) (on by default) 'hg id -n' short commit it from hg repo
  b.) read from ad_module.xml (non default)
- In contrast ant package.module does not modify version but just creates obx file itself. It could make sense to simplify and package.core to do the same
- rm team currently does not use package.core but creates zip file for core manually but would like to use some more standard solution
- Ideally modified package.core would work needing install.source or prior compilation if possible
(0119139)
shuehner   
2020-04-13 17:56   
After discussion ALO/SHU: As the task is not even used by RM team to prepare releases -> Removal:

https://gitlab.com/openbravo/product/openbravo/-/merge_requests/57 [^]
(0119160)
hgbot   
2020-04-14 18:34   
Repository: erp/devel/pi
Changeset: c130f7d85747d2ff9cd2038c4138ea15b9e8b289
Author: Stefan Huehner <stefan.huehner <at> openbravo.com>
Date: Mon Apr 13 17:43:09 2020 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c130f7d85747d2ff9cd2038c4138ea15b9e8b289 [^]

fixed ISSUE-42775: Remove ant task package.core (mercurial only and unused)

That task tied to mercurial revision control (by using hg id & hg
archive, so for upcoming git migration it will stop working).
Apart it is not used by Openbravo to prepare releases so not really
needed.

Instead of rewriting it with git or hg & git logic lets remove it.

---
M build.xml
---