Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042749Openbravo ERPA. Platformpublic2020-01-08 15:352020-03-20 17:54
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042749: Apply new HQL Style in MatchStatementOnLoadGetPreferenceActionHandler.java
DescriptionMatchStatementOnLoadGetPreferenceActionHandler.java has one HQL query with:
- the HQL is hard to read because of formatting
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-08 15:35inigo_lergaNew Issue
2020-01-08 15:35inigo_lergaAssigned To => inigo_lerga
2020-01-08 15:35inigo_lergaModules => Core
2020-01-08 15:35inigo_lergaTriggers an Emergency Pack => No
2020-01-08 15:35inigo_lergaStatusnew => scheduled
2020-01-09 11:21inigo_lergaNote Added: 0116727
2020-01-10 14:44inigo_lergaRelationship addedrelated to 0041287
2020-01-13 18:18hgbotCheckin
2020-01-13 18:18hgbotNote Added: 0116809
2020-01-13 18:19dmiguelezStatusscheduled => resolved
2020-01-13 18:19dmiguelezFixed in Version => 3.0PR20Q2
2020-01-13 18:19dmiguelezFixed in SCM revision => https://code.openbravo.com/erp/devel/pi/rev/f0b541fa2fa175767e42a6d835df2e7815fc646d [^]
2020-01-13 18:19dmiguelezResolutionopen => fixed
2020-01-13 18:19dmiguelezReview Assigned To => dmiguelez
2020-01-13 18:19dmiguelezNote Added: 0116810
2020-01-13 18:19dmiguelezStatusresolved => closed
2020-03-20 17:54hudsonbotCheckin
2020-03-20 17:54hudsonbotNote Added: 0118728

Notes
(0116727)
inigo_lerga   
2020-01-09 11:21   
Test Plan Mantis:
As the F&B International Group Admin role:
    - Go to the Financial Account window and
      enter the record named "Bank - Account 1".
    - Press the Match Statement button.
#In this moment the modified HQL is executed#
(0116809)
hgbot   
2020-01-13 18:18   
Repository: erp/devel/pi
Changeset: f0b541fa2fa175767e42a6d835df2e7815fc646d
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Jan 09 11:15:59 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f0b541fa2fa175767e42a6d835df2e7815fc646d [^]

Related to Issue 42749: Applied new HQL Style

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadGetPreferenceActionHandler.java
---
(0116810)
dmiguelez   
2020-01-13 18:19   
Code Review + Testing Ok
(0118728)
hudsonbot   
2020-03-20 17:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b31620115262 [^]
Maturity status: Test