Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042738Openbravo ERPA. Platformpublic2020-01-08 14:012020-03-20 17:54
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042738: Apply new HQL Style in CheckExistsOverissueBinForRFCShipmentWH.java
DescriptionCheckExistsOverissueBinForRFCShipmentWH.java has one HQL query to update with:
- the HQL is hard to read because of formatting
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-08 14:01inigo_lergaNew Issue
2020-01-08 14:01inigo_lergaAssigned To => platform
2020-01-08 14:01inigo_lergaOBNetwork customer => No
2020-01-08 14:01inigo_lergaModules => Core
2020-01-08 14:01inigo_lergaTriggers an Emergency Pack => No
2020-01-08 14:01inigo_lergaStatusnew => scheduled
2020-01-08 14:01inigo_lergaAssigned Toplatform => inigo_lerga
2020-01-09 10:18inigo_lergaNote Added: 0116725
2020-01-10 14:43inigo_lergaRelationship addedrelated to 0041287
2020-01-13 09:58hgbotCheckin
2020-01-13 09:58hgbotNote Added: 0116784
2020-01-13 09:59dmiguelezStatusscheduled => resolved
2020-01-13 09:59dmiguelezFixed in Version => 3.0PR20Q2
2020-01-13 09:59dmiguelezFixed in SCM revision => https://code.openbravo.com/erp/devel/pi/rev/3b1dccac736da20765833a735d4a7182a58e3513 [^]
2020-01-13 09:59dmiguelezResolutionopen => fixed
2020-01-13 09:59dmiguelezReview Assigned To => dmiguelez
2020-01-13 09:59dmiguelezNote Added: 0116785
2020-01-13 09:59dmiguelezStatusresolved => closed
2020-03-20 17:54hudsonbotCheckin
2020-03-20 17:54hudsonbotNote Added: 0118727

Notes
(0116725)
inigo_lerga   
2020-01-09 10:18   
Test Plan Mantis:
As the F&B International Group Admin role:
    - Go to the Purchase Order window and create
      a new record with "Bebidas Alegres, S.l" as
      Business Partner. Add a line with 5 units of
      "Cerveza Ale 0.5L". Save and Complete the Order.
    - Go to the Goods Receipt window and create a
      new record with "Bebidas Alegres, S.l" as
      Business Partner. Press the Create Lines From button
      and select the order created above and click Ok.
      Save and Complete the Receipt.
    - Go to Return to Vendor window and create a
      new record with "Bebidas Alegres, S.l" as
      Business Partner. Press the Pick/Edit Lines
      button and select the 5 units of "Cerveza Ale 0.5L"
      previously used. Press the Done button and Book
      the Return.
    - Go to Goods Shipment window and create a new record
      with any Business Partner. Add a new Line with
      "Cerveza Ale 0.5L" and all the units avaiable in
      stock (default number), so there is no stock left.
      Complete the Shipment.
    - Go to Return to Vendor Shipment and create a new
      record with "Bebidas Alegres, S.l" as Business Partner.
      Press the Pick/Edit Lines button and select any row.
#In this moment the modified HQL is executed#
(0116784)
hgbot   
2020-01-13 09:58   
Repository: erp/devel/pi
Changeset: 3b1dccac736da20765833a735d4a7182a58e3513
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Jan 08 16:55:14 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3b1dccac736da20765833a735d4a7182a58e3513 [^]

Related to Issue 42738: Applied new HQL Style

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/CheckExistsOverissueBinForRFCShipmentWH.java
---
(0116785)
dmiguelez   
2020-01-13 09:59   
Code Review + Testing Ok
(0118727)
hudsonbot   
2020-03-20 17:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b31620115262 [^]
Maturity status: Test