0042702: Rounding problem on posting matched invoices in certain cases when the result has an inifinite number of decimals

Openbravo Issue Tracking System - Openbravo ERP
View Issue Details

ID	Project	Category	View Status	Date Submitted	Last Update
0042702	Openbravo ERP	03. Procurement management	public	2020-01-06 17:35	2020-03-20 17:54

Reporter	agonzalez
Assigned To	AtulOpenbravo
Priority	high	Severity	major	Reproducibility	always
Status	closed	Resolution	fixed
Platform		OS	5	OS Version
Product Version	3.0PR18Q3.3
Target Version		Fixed in Version	3.0PR20Q2
Merge Request Status
Review Assigned To	dmiguelez
OBNetwork customer	OBPS
Web browser	Google Chrome
Modules	Core
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency Pack	No

Summary	0042702: Rounding problem on posting matched invoices in certain cases when the result has an inifinite number of decimals
Description	There is a problem while calculating the expenses of the transaction being posted. When the movement quantity of the goods receipt, the quantity invoiced of the invoice and the line net amount of the first line contains certain values, it could happen that the result of the calculation of the expenses generates a result with infinite results, causing a ArithmeticException as there is not a RoundingMode defined. Please find attached a copy of the generated exception and follow the specified steps to reproduce, as this problems can be reproduced only certain conditions. The code fragment that needs to be changed is on the DocMatchInv class and you will find a patch attached to the issue that seems to solve the problem.
Steps To Reproduce	----------------------- CONFIGURATION REQUIRED ----------------------- * The currency used for the invoice must have a price precision of 4 ----------------------- STEPS ----------------------- 1. Create an invoice and add a line, with a product that contains "150452" as invoiced quantity and "1.059" as net unit price. (Process the invoice) 2. At this point, the line net amount for the created line should be "159,328.67" 3. Create a goods receipt, and copy the lines from the created invoice, and in the movement quantity, set the following quantity: "4156" (Process the goods receipt) 4. Go to the matched invoices window and find the recently created invoice associated with the recently created goods receipt. 5. Click on "Post". An error will be displayed: "Process failed during execution" and an exception log will be generated on the openbravo log. You will find the generated exception on the attached files. NOTE: This case could be repeated with another quantities if the result of the following operation returns a result with infinite decimals: (line net amount * movement quantity) / quantity invoiced
Proposed Solution	Add a rounding mode to the line in the DocMatchInv where the expenses are calculated. A patch was uploaded.
Additional Information
Tags	No tags attached.
Relationships
Attached Files	patch_rounding.patch (675) 2020-01-06 17:35 https://issues.openbravo.com/file_download.php?file_id=13757&type=bug RoundingProblem.clear (4,298) 2020-01-06 17:36 https://issues.openbravo.com/file_download.php?file_id=13758&type=bug

Issue History
Date Modified	Username	Field	Change
2020-01-06 17:35	agonzalez	New Issue
2020-01-06 17:35	agonzalez	Assigned To	=> Triage Finance
2020-01-06 17:35	agonzalez	File Added: patch_rounding.patch
2020-01-06 17:35	agonzalez	Web browser	=> Google Chrome
2020-01-06 17:35	agonzalez	Modules	=> Core
2020-01-06 17:35	agonzalez	Triggers an Emergency Pack	=> No
2020-01-06 17:36	agonzalez	File Added: RoundingProblem.clear
2020-01-20 13:37	ngarcia	OBNetwork customer	=> OBPS
2020-01-20 13:37	ngarcia	Web browser	Google Chrome => Google Chrome
2020-01-22 09:17	ngarcia	Web browser	Google Chrome => Google Chrome
2020-01-22 09:17	ngarcia	Resolution time	=> 1581462000
2020-01-22 09:17	ngarcia	Priority	normal => high
2020-01-22 09:17	ngarcia	Severity	minor => major
2020-01-22 11:04	dmiguelez	Assigned To	Triage Finance => AtulOpenbravo
2020-01-23 08:08	AtulOpenbravo	Status	new => scheduled
2020-01-24 05:58	AtulOpenbravo	Note Added: 0117209
2020-01-24 05:59	AtulOpenbravo	Note Edited: 0117209	bug_revision_view_page.php?bugnote_id=0117209#r20213
2020-01-24 05:59	AtulOpenbravo	Note Edited: 0117209	bug_revision_view_page.php?bugnote_id=0117209#r20214
2020-01-31 08:30	hgbot	Checkin
2020-01-31 08:30	hgbot	Note Added: 0117387
2020-01-31 08:30	hgbot	Status	scheduled => resolved
2020-01-31 08:30	hgbot	Resolution	open => fixed
2020-01-31 08:30	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/d70bc108e8d238c04608becfab7b6854eec68b1a [^]
2020-01-31 08:30	hgbot	Checkin
2020-01-31 08:30	hgbot	Note Added: 0117388
2020-01-31 08:31	dmiguelez	Review Assigned To	=> dmiguelez
2020-01-31 08:31	dmiguelez	Note Added: 0117389
2020-01-31 08:31	dmiguelez	Status	resolved => closed
2020-01-31 08:31	dmiguelez	Fixed in Version	=> 3.0PR20Q2
2020-01-31 09:29	hgbot	Checkin
2020-01-31 09:29	hgbot	Note Added: 0117396
2020-03-20 17:54	hudsonbot	Checkin
2020-03-20 17:54	hudsonbot	Note Added: 0118736

Notes

Test Plan

- Login as System Admin
- Navigate to Currency window, select current EUR and set Price Precision as 4
- Log Out.

In Format.xml, set

<Number name="priceInform"
       decimal="." grouping="," formatOutput="#,##0.000" formatInternal="#0.000" />
   <Number name="priceRelation"
       decimal="." grouping="," formatOutput="#,##0.000" formatInternal="#0.000" />
   <Number name="priceEdition"
       decimal="." grouping="," formatOutput="#0.000" formatInternal="#0.000" />

and

<Number name="amountInform"
       decimal="." grouping="," formatOutput="#,##0.000" formatInternal="#0.000" />

- Run ant smartbuild

- Login as F&B International Group Admin
- Navigate to Purchase Invoice Window
- Create Purchase Invoice in F&B Espana Org, Bebidas Alegres, S.L. business partner.
- Create a Line for Product:Cerveza Ale 0,5L, Quantity = 150452, Price = 1.059
- Realize that Line Net amount is set 159328.67
- Complete Invoice.
- Navigate to Goods Receipt Window
- Create a Goods Receipt in F&B Espana Org, Bebidas Alegres, S.L. business partner.
- Using Create Lines from, select previously created purchase invoice in the Invoice Selector
- Realize that Line for Product Cerveza Ale 0,5L is loaded.
- Select the line, set Quantity to 4156, Storage Bin = RN-0-0-0
- Click on OK button.
- Complete the Goods Receipt.
- Schedule Costing Background process so that cost is calculated for related transactions.
- Navigate to Matched Invoice window and select the one which is linked with above Purchase Invoice Line and Goods Receipt Line.
- Post the record, Realize that posting is successful. (If there is error Account not found error then Navigate to product: Cerveza Ale 0,5L, Accounting Tab: set Invoice Price Variance account to some account to avoid error )
- Posting is as below:-

Key----Account

2120---Goods Received and not invoiced--6,386.94--Debit
5360---Product Expense------------------------6,386.94--Credit